<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body> <div style="font-family:sans-serif"><div style="white-space:normal"> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">My current thinking is is that we deploy this PR against latest-master </div><div dir="auto">of everything else. eg. a PR for 'core' would deploy against last </div><div dir="auto">deployed api and db. Similarly the PR for core would deploy with the </div><div dir="auto">last good UI and db etc ; but each time, the entire stack is brought </div><div dir="auto">up as an app, and exposed under its own set of hostnames.[1] </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">sounds reasonable.</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">Since the PR can come from different services, we would need to map </div><div dir="auto">that via the hostname for clarity eg: core-pr25.<qdn> or ui-pr40.<qdn> e </div><div dir="auto">tc </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">+1</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">Two primary concerns at this point are : </div><div dir="auto">1) it will almost always be a blank db. </div><div dir="auto">2) it will be had to have a api change be visible in sync with a </div><div dir="auto">proposed UI PR. </div><div dir="auto"> </div><div dir="auto">for (1) the easy route is to do a db dump from demo.db and load that </div><div dir="auto">into the db brought up for the instance. However, given that this </div><div dir="auto">brings with it the risk of exposing otherwise-private or privileged </div><div dir="auto">info, we should never really do that. The middle ground between </div><div dir="auto">no-data and all-the-data is to have a test dataset. Is this something </div><div dir="auto">we can do ? if so, we can workout the mechanics of storing it and </div><div dir="auto">loading/validating it. </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">I would say we would <em>have</em> to be able to load the system with test data.<br> Any system I worked on that had it became so much better by it.</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">Given the present dataset live at demo.a.i, generating this test data </div><div dir="auto">might just be a case of dumping the present dataset into sql and </div><div dir="auto">checking it into the git repos. </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">Yes, keep it simple.</p> <p dir="auto"></p></div> <div style="white-space:pre-wrap"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><div dir="auto">for (2) the solution will likely be in finding a way to parse and </div><div dir="auto">establish the cross services PR relationship via the github comments. </div><div dir="auto">However, given the complexity in that, and given that the actual CD </div><div dir="auto">pipeline for the service as a while will need to be atomic - I propose </div><div dir="auto">that the PR test stages also be atomic. If a UI function needs core </div><div dir="auto">functionality, it should be built, tested and deployed via core first </div><div dir="auto">then exercised via the UI. </div></blockquote></div> <div style="white-space:normal"> <p dir="auto">I think that is what we would have to do for now.</p> <p dir="auto">I wonder if the way to handle the cross-cutting PR's is to instead of having Core and UI<br> in separate repos is to have them together and then split repos based on micro service vertical slices<br> rather than horizontal slices ? </p> <p dir="auto">its also one of the tenants of 12factor.net (<a href="https://12factor.net/codebase" style="color:#3983C4">https://12factor.net/codebase</a>) that I think makes a lot of sense<br> for our kind of app(s).</p> <p dir="auto">With this much less magic needed IMO. WDYT ? </p> <p dir="auto">/max<br> <a href="http://about.me/maxandersen" style="color:#3983C4">http://about.me/maxandersen</a></p> </div> </div> </body> </html>