<div dir="ltr">Konrad; Excellent. Does that remove it from the 'Status/Check' list on PR as well? Or do we need to unregister the repo in Reviewable somewhere?</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 18, 2016 at 10:46 PM, Konrad Kleine <span dir="ltr"><<a href="mailto:kkleine@redhat.com" target="_blank">kkleine@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Aslak,<div><br></div><div>I've updated the webkook for reviewable to be inactive (<a href="https://github.com/almighty/almighty-core/settings/hooks/9026487" target="_blank">https://github.com/almighty/<wbr>almighty-core/settings/hooks/<wbr>9026487</a>). It can be activated at any time.</div><div><br></div><div>Regards,</div><div>Konrad</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 19, 2016 at 2:11 AM, Aslak Knutsen <span dir="ltr"><<a href="mailto:aslak@redhat.com" target="_blank">aslak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Don't listen to Todd, his answering in his sleep... :)<div><br></div><div>The main reason we moved to Reviewable was to keep track of 'unanswered' comments during large reviews. I'm not seeing 100% how the new GitHub review fixes this, but, the new GitHub Review definitely has nicer reviews than before and with generally smaller pull requests I think we should be able to use it with no problem.</div><div><br></div><div>My take would be; Let's try GitHub Review for a while and see if it works for what we need. If not, we can move back to Reviewable later.</div><div><br></div><div>-aslak- </div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Sun, Sep 18, 2016 at 9:06 PM, Todd Mancini <span dir="ltr"><<a href="mailto:tmancini@redhat.com" target="_blank">tmancini@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div><div><div style="font-family:Calibri,sans-serif;font-size:11pt">Yes, we should continue with our implementation. There are many reasons, but the main reason is that, although we are using GitHub today, the future plans do not require GitHub.<br><br>Sent from my phone, so anticipate hilarious autocorrects</div></div><div dir="ltr"><hr><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">From: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:shbose@redhat.com" target="_blank">Shoubhik Bose</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Sent: </span><span style="font-family:Calibri,sans-serif;font-size:11pt">9/16/2016 2:57 AM</span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">To: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:almighty-public@redhat.com" target="_blank">ALMighty-public</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Subject: </span><span style="font-family:Calibri,sans-serif;font-size:11pt">[almighty] Code review integration</span><br><br></div></div><div><div><div dir="ltr">Github has added new features for tracking code review , should we be continuing with reviewable ?<br></div>
</div></div><br></div></div>______________________________<wbr>_________________<br>
almighty-public mailing list<br>
<a href="mailto:almighty-public@redhat.com" target="_blank">almighty-public@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/almighty-public</a><br>
<br></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
almighty-public mailing list<br>
<a href="mailto:almighty-public@redhat.com" target="_blank">almighty-public@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/almighty-public</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>