<div dir="ltr">Great stuff!<div><br></div><div>As a bonus I might recommend taking these practices that Sudipta has compiled and throwing them into the Almighty devdocs. :)</div><div><br>S,</div><div>ALR</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 19, 2016 at 8:19 AM, Sudipta Sen <span dir="ltr"><<a href="mailto:sudsen@redhat.com" target="_blank">sudsen@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure. It'll be a nice guide line.<br></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Mon, Sep 19, 2016 at 4:05 PM, Konrad Kleine <span dir="ltr"><<a href="mailto:kkleine@redhat.com" target="_blank">kkleine@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sorry, wrong PR. This one is the correct one: <a href="https://github.com/almighty/almighty-core/pull/249" target="_blank">https://github.com/almigh<wbr>ty/almighty-core/pull/249</a> This one applies some of the proposed guidelines: <a href="https://github.com/almighty/almighty-core/pull/240" style="font-size:12.8px" target="_blank">https://github.com<wbr>/almighty/almighty-core/pull/<wbr>240</a></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 19, 2016 at 12:33 PM, Konrad Kleine <span dir="ltr"><<a href="mailto:kkleine@redhat.com" target="_blank">kkleine@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Sudipta,<div><br></div><div>I've create a commit a few days ago and lately a PR. Maybe we can integrate your or ALR's ideas into that document.</div><div><br></div><div><a href="https://github.com/almighty/almighty-core/pull/240" target="_blank">https://github.com/almighty/al<wbr>mighty-core/pull/240</a></div><div><br></div><div>So far I've just added notes on a few techniques in Go that are special.</div><div><br></div><div>Regards,</div><div>Konrad<br><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Sep 16, 2016 at 12:00 PM, Sudipta Sen <span dir="ltr"><<a href="mailto:sudsen@redhat.com" target="_blank">sudsen@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">In order to do development : <br><div><br>* Fork it <br>* Identify the issue<br>* Post the issue and discuss <br>* Branch out of master with a sensible name ( Use the issue ID in the name for reference )<br>* Run test on your new branch<br>* Write a test on your hypothesis <br> * Name the test with a sensible one.<br> * Create a test that fails showing the issue<br> * Give a comment with the issue ID.<br> * Sensible test error message should contain the issue ID for reference.<br> * Follow Idempotent in test.<br> * Write a test that can be run again and again.<br> * That test should not have any side effect.<br>* git status to see all the changes that you have made so far.<br>* git diff to review your code changes so far.<br>* git commit -a the changes with a sensible commit message, maybe with the issue ID for reference.<br>* git checkout master<br>* git pull upstream master<br>* git checkout <your branch><br>* git rebase master<br> * Fix all the conflicts<br>* git push <your remote> <your branch><br>* Create a pull request to the master.<br>* After the pull request is accepted it’ll be in master of upstream.<br>* Delete your branch locally and remote as well.<span><font color="#888888"><br clear="all"><br><div><div dir="ltr"><span><div><div dir="ltr"><br><br>-- <br><span><font color="#888888"><span></span></font></span><font color="#171314"><span style="font-size:16px"><b>Sudipta Sen<br></b>Software Engineer<b><br></b></span></font><span style="background-color:rgb(255,255,255)"><span style="color:rgb(255,0,0)"><br>M: </span></span><span style="color:rgb(0,0,0)">(+91) 906 625 8469</span><br><span style="color:rgb(253,183,45)"><span style="color:rgb(255,0,0)">E:</span> <span style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">sudsen</span></span></span><a style="color:rgb(67,67,67);text-decoration:none" href="mailto:brittney@gopassport.com" target="_blank">@redhat.com</a><br><span><span style="color:rgb(253,183,45)"><span style="color:rgb(255,0,0)">E:</span> <span style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">sanborn.sen</span></span></span><a style="color:rgb(67,67,67);text-decoration:none" href="mailto:brittney@gopassport.com" target="_blank">@gmail.com</a></span><a style="color:rgb(67,67,67);text-decoration:none" href="http://www.gopassport.com/" target="_blank"><span style="background-color:rgb(255,255,255)"><span></span></span></a><br><br><a style="color:rgb(17,85,204)" href="https://www.facebook.com/ssudipta.ssen" target="_blank"><img src="https://s3.amazonaws.com/passportmedia/emailsig/facebook.png" alt="Facebook"></a> <a style="color:rgb(17,85,204)" href="https://in.linkedin.com/in/sudipta-sen-16247455" target="_blank"><img src="https://s3.amazonaws.com/passportmedia/emailsig/linkedin.png" alt="Linkedin"></a> <a style="color:rgb(17,85,204)" href="https://twitter.com/SudiptaSen7" target="_blank"><img src="https://s3.amazonaws.com/passportmedia/emailsig/twitter.png" alt="Twitter"></a> <br><br><span><span><a href="http://redhat.com/" target="_blank"><img src="https://www.google.com/a/redhat.com/images/logo.gif" alt="http://redhat.com/" height="51" width="124"></a></span></span></div></div></span></div></div> </font></span></div></div> <br></div></div>______________________________<wbr>_________________<br> almighty-public mailing list<br> <a href="mailto:almighty-public@redhat.com" target="_blank">almighty-public@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/almighty-public</a><br> <br></blockquote></div><br></div> </blockquote></div><br></div> </div></div></blockquote></div><br><br clear="all"><br></div></div>-- <br><span class=""><div data-smartmail="gmail_signature"><div dir="ltr"><span><div><div dir="ltr">-- <br><span><font color="#888888"><span></span></font></span><font color="#171314"><span style="font-size:16px"><b>Sudipta Sen<br></b>Software Engineer<b><br></b></span></font><span style="background-color:rgb(255,255,255)"><span style="color:rgb(255,0,0)"><br>M: </span></span><span style="color:rgb(0,0,0)">(+91) 906 625 8469</span><br><span style="color:rgb(253,183,45)"><span style="color:rgb(255,0,0)">E:</span> <span style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">sudsen</span></span></span><a href="mailto:brittney@gopassport.com" style="color:rgb(67,67,67);text-decoration:none" target="_blank">@redhat.com</a><br><span><span style="color:rgb(253,183,45)"><span style="color:rgb(255,0,0)">E:</span> <span style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">sanborn.sen</span></span></span><a href="mailto:brittney@gopassport.com" style="color:rgb(67,67,67);text-decoration:none" target="_blank">@gmail.com</a></span><a href="http://www.gopassport.com/" style="color:rgb(67,67,67);text-decoration:none" target="_blank"><span style="background-color:rgb(255,255,255)"><span></span></span></a><br><br><a href="https://www.facebook.com/ssudipta.ssen" style="color:rgb(17,85,204)" target="_blank"><img alt="Facebook" src="https://s3.amazonaws.com/passportmedia/emailsig/facebook.png"></a> <a href="https://in.linkedin.com/in/sudipta-sen-16247455" style="color:rgb(17,85,204)" target="_blank"><img alt="Linkedin" src="https://s3.amazonaws.com/passportmedia/emailsig/linkedin.png"></a> <a href="https://twitter.com/SudiptaSen7" style="color:rgb(17,85,204)" target="_blank"><img alt="Twitter" src="https://s3.amazonaws.com/passportmedia/emailsig/twitter.png"></a> <br><br><span><span><a href="http://redhat.com/" target="_blank"><img alt="http://redhat.com/" src="https://www.google.com/a/redhat.com/images/logo.gif" width="124" height="51"></a></span></span></div></div></span></div></div> </span></div> <br>______________________________<wbr>_________________<br> almighty-public mailing list<br> <a href="mailto:almighty-public@redhat.com">almighty-public@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/almighty-<wbr>public</a><br> <br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Red Hat Developer Programs Architecture<div>@ALRubinger</div></div></div> </div>