<div dir="ltr"><div><div>How about per PR build? Do they run in a production or dev setting? </div>Warm Regards, </div>Nimisha </div><div class="gmail_extra"> <div class="gmail_quote">On Sat, Jan 14, 2017 at 12:15 AM, Max Andersen <<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Great you resolved the issue Michael! One thought about build being published when failing. Maybe it has same issue as devdoc had and script doesn't return the right return code. /max <a href="http://about.me/maxandersen" rel="noreferrer" target="_blank">http://about.me/maxandersen</a> <div class="HOEnZb"><div class="h5"> > On 13 Jan 2017, at 09:58, Michael Kleinhenz <<a href="mailto:kleinhenz@redhat.com">kleinhenz@redhat.com</a>> wrote: > > Hi Team, > > the <a href="http://demo.almighty.io" rel="noreferrer" target="_blank">demo.almighty.io</a> service went down yesterday for a couple of > minutes. The problem is now fixed and the server is back up, but I > found two underlying, more general problems. Here's my findings in > bullet points: > > - We had a problem on code level yesterday in master. That problem > should have been easily > detected by our test chain. But it was not. > > - currently, the functional tests are run against an intermediate > build. We're using the > WebPack dev/debug function for that. Only after they succeed, the > final build is done > and the output artifact created. The reason is that we don't need a > test-only http-server setup > as WebPack already includes that. > > - I found out that the error caused by the problem in master was > apperaring ONLY when > doing a production build, NOT when doing a debug/dev build. The > result was, that the problem > was completely invisible in a dev environment and for the functional > tests. I don't know yet, why > the dev and prod build done by WebPack are behaving differently at a > such elementary level. > > - The above WebPack mystery would have not affected demo.almighty > without a second problem: > the build was deployed to demo.almighty althought it failed > building. Resulting in just index.html > deployed to the server (!). > > - I suspect that errors appearing inside the build container are > somehow not propagated to the > outside Jenkins build. They may just be consumed somewhere. > > - The second problem (build errors do not get propagated) is the more > severe one and also may > affect other builds in other projects as we basically just re-used that setup. > > Action points: > > - We need to check if we can run the functional tests against the > production build instead of the > intermediate build. > -> <a href="https://github.com/fabric8io/fabric8-planner/issues/741" rel="noreferrer" target="_blank">https://github.com/fabric8io/fabric8-planner/issues/741</a> > > - We need to check the build process to find out why errors are not > propagated to the outside > world (or being recognized as a fail by Jenkins). > -> <a href="https://github.com/fabric8io/fabric8-planner/issues/742" rel="noreferrer" target="_blank">https://github.com/fabric8io/fabric8-planner/issues/742</a> > > - We need to fix the actual code problems that triggered the above. > -> <a href="https://github.com/fabric8io/fabric8-planner/issues/732" rel="noreferrer" target="_blank">https://github.com/fabric8io/fabric8-planner/issues/732</a> > > -- Michael > > -- > Michael Kleinhenz > Principal Software Engineer > > Red Hat Deutschland GmbH > Werner-von-Siemens-Ring 14 > 85630 Grasbrunn > Germany > > RED HAT | TRIED. TESTED. TRUSTED. > Red Hat GmbH, <a href="http://www.de.redhat.com" rel="noreferrer" target="_blank">www.de.redhat.com</a>, > Registered seat: Grasbrunn, Commercial register: Amtsgericht München, > HRB 153243, > Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, > Michael O'Neill > > _______________________________________________ > almighty-public mailing list > <a href="mailto:almighty-public@redhat.com">almighty-public@redhat.com</a> > <a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/almighty-public</a> > > _______________________________________________ almighty-public mailing list <a href="mailto:almighty-public@redhat.com">almighty-public@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/almighty-public" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/almighty-public</a> </div></div></blockquote></div> </div>