From jesusr at redhat.com Fri Jul 7 20:12:35 2017 From: jesusr at redhat.com (jesus m. rodriguez) Date: Fri, 07 Jul 2017 16:12:35 -0400 Subject: [Ansible-service-broker] Proposal: broker authentication Message-ID: <1499458355.10841.11.camel@redhat.com> Continuing the specs for the sprint, here is the broker authentication spec. https://github.com/openshift/ansible-service-broker/pull/260 I'm doing things a little different for this spec. We tried doing things a few different ways, I'm hoping this might be the best of all worlds. * spec as a github issue * public making it accessible * difficult to comment on specific line * difficult to keep track of comments * no history of revisions * google docs * not able to make public outside Red Hat * ability to comment on specific lines * lengthy discussions were hard to keep track of * no history of revisions Here is the hope for the PR process: * public * easy to comment on specific lines * familiar process to other code reviews * becomes part of the repo, can reference later * lengthy discussions seem easier to deal with Sincerely, jesus From shurley at redhat.com Tue Jul 11 12:29:11 2017 From: shurley at redhat.com (Shawn Hurley) Date: Tue, 11 Jul 2017 08:29:11 -0400 Subject: [Ansible-service-broker] Whitelist/blacklist and multiple registries overlap Message-ID: <05f8d9b7-0c26-d1d2-02de-a6106af3d5ec@redhat.com> Hey guys, Today we found alot of overlap between the black list and white list card(https://trello.com/c/yuLBrRdC/297-13-ability-to-whitelist-blacklist-apbs) and the multiple registries card(https://trello.com/c/1KqTacLK/304-8-multiple-registry-adapters-configured-in-one-broker-instance). We (Erik, Jesus, Shawn) determined the next steps that Erik and Shawn will work on. Here is a quick summery just to keep everyone in the loop. The general theme is moving shared behavior into the broker layer and to the registry layer. This will allow adapters to be built in a way that gets white list and black list for free. We also discussed some issues with the current ID coming from the apb. Because of this we are going to create a unique value we are calling a FQName(fully qualified name) that we will hash to create the SPEC ID. We will create a card to capture the work around removing it from the apbs, rebuilding the apbs and removing it from the apb tooling. *Implementation details*: We will rename the 'name' field on the spec struct to 'FQName'. This will be the fully qualified name of an APB(includes registry prefix/url + org + image name + tag example: docker.io/apb/mediawiki-123:release-0.9). The broker is responsible for creating and setting this value during bootstrap. We will ignore the ID given in apb.yml of the spec and instead use a md5 hash of the FQName. This is to allow the service catalog be able to reconcile service instances. Move registries to its own package in pkg/ Create an adapter package in the registries package Create an RegistryAdapter interface Having 3 Methods * RegistryName - The adapter should now about its prefix I.E. docker.io/ * GetImages - adapter will retrieve all the image name * FetchSpecs - takes a list of images and retrieves the specs for the image names. Add method imageToSpec to adapters package Create Registry Struct that takes a Filter object and an Adapter object LoadSpecs will be defined here. Thanks, Erik, Jesus, Shawn From ernelson at redhat.com Thu Jul 13 20:01:33 2017 From: ernelson at redhat.com (Erik Nelson) Date: Thu, 13 Jul 2017 16:01:33 -0400 Subject: [Ansible-service-broker] NOTICE: A couple large features hitting master today Message-ID: We're going to be merging the change to credential extraction; it's a couple PRs across the broker and apb-examples repo. Since there are apb-base changes, we'll need to be rebuild and push all the apbs upstream. https://github.com/fusor/apb-examples/pull/25 https://github.com/openshift/ansible-service-broker/pull/124 Following this, we're hoping to merge an open feature branch either today or tomorrow that brings in multi-registry support, as well as white/blacklisting of apbs on a registry basis. https://github.com/openshift/ansible-service-broker/pull/271 It's possible there may be some bumps along the way. Please raise any objections to this or issues in IRC or on this list. Thanks! From ernelson at redhat.com Thu Jul 13 21:27:39 2017 From: ernelson at redhat.com (Erik Nelson) Date: Thu, 13 Jul 2017 17:27:39 -0400 Subject: [Ansible-service-broker] Fwd: NOTICE: A couple large features hitting master today In-Reply-To: References: Message-ID: Update: The bind PRs were merged and I pushed a new broker image to ansibleplaybookbundle org. I rebuilt and pushed apb-base, rhscl-postgresql-apb, and mediawiki123-apb. I'm not famiilar with the other examples, but it's likely they'll also need rebuilds from the Dockerfile-src files. If someone can confirm that, I can rebuild the other images. All existing images were backed up with a tag 07132013. I'm going to try to run through a vanilla catasb regression run from the ansibleplaybookbundle org tonight to make sure things are looking good. Thanks! ---------- Forwarded message ---------- From: Erik Nelson Date: Thu, Jul 13, 2017 at 4:01 PM Subject: NOTICE: A couple large features hitting master today To: ansible-service-broker at redhat.com We're going to be merging the change to credential extraction; it's a couple PRs across the broker and apb-examples repo. Since there are apb-base changes, we'll need to be rebuild and push all the apbs upstream. https://github.com/fusor/apb-examples/pull/25 https://github.com/openshift/ansible-service-broker/pull/124 Following this, we're hoping to merge an open feature branch either today or tomorrow that brings in multi-registry support, as well as white/blacklisting of apbs on a registry basis. https://github.com/openshift/ansible-service-broker/pull/271 It's possible there may be some bumps along the way. Please raise any objections to this or issues in IRC or on this list. Thanks! From ernelson at redhat.com Thu Jul 13 22:08:38 2017 From: ernelson at redhat.com (Erik Nelson) Date: Thu, 13 Jul 2017 18:08:38 -0400 Subject: [Ansible-service-broker] Fwd: NOTICE: A couple large features hitting master today In-Reply-To: References: Message-ID: Last Update: I ran through the provision/bind workflow with images out of ansibleplaybookbundle, confirmed its using the new bind code and everything was successful, so the new images should be good to go. ---------- Forwarded message ---------- From: Erik Nelson Date: Thu, Jul 13, 2017 at 5:27 PM Subject: Fwd: NOTICE: A couple large features hitting master today To: ansible-service-broker at redhat.com Update: The bind PRs were merged and I pushed a new broker image to ansibleplaybookbundle org. I rebuilt and pushed apb-base, rhscl-postgresql-apb, and mediawiki123-apb. I'm not famiilar with the other examples, but it's likely they'll also need rebuilds from the Dockerfile-src files. If someone can confirm that, I can rebuild the other images. All existing images were backed up with a tag 07132013. I'm going to try to run through a vanilla catasb regression run from the ansibleplaybookbundle org tonight to make sure things are looking good. Thanks! ---------- Forwarded message ---------- From: Erik Nelson Date: Thu, Jul 13, 2017 at 4:01 PM Subject: NOTICE: A couple large features hitting master today To: ansible-service-broker at redhat.com We're going to be merging the change to credential extraction; it's a couple PRs across the broker and apb-examples repo. Since there are apb-base changes, we'll need to be rebuild and push all the apbs upstream. https://github.com/fusor/apb-examples/pull/25 https://github.com/openshift/ansible-service-broker/pull/124 Following this, we're hoping to merge an open feature branch either today or tomorrow that brings in multi-registry support, as well as white/blacklisting of apbs on a registry basis. https://github.com/openshift/ansible-service-broker/pull/271 It's possible there may be some bumps along the way. Please raise any objections to this or issues in IRC or on this list. Thanks! From jmatthew at redhat.com Fri Jul 14 11:39:31 2017 From: jmatthew at redhat.com (John Matthews) Date: Fri, 14 Jul 2017 07:39:31 -0400 Subject: [Ansible-service-broker] Broken fusor/catasb 'dev' due to 'dependency' data in rebuilt APBs and WebUI BZ? Message-ID: I noticed a new run of catasb/fusor 'dev' resulted in the WebUi 'spinning'. I assume this is related to the change we made yesterday of adding in dependency metadata on each APB and rebuilding them? Way I understand it, the Service Catalog is reading the data correctly, but the WebUI is breaking to the unexpected fields in 'metadata'. $ oc get serviceclasses NAME KIND etherpad-apb ServiceClass.v1alpha1.servicecatalog.k8s.io hello-world-apb ServiceClass.v1alpha1.servicecatalog.k8s.io manageiq-apb ServiceClass.v1alpha1.servicecatalog.k8s.io mediawiki123-apb ServiceClass.v1alpha1.servicecatalog.k8s.io pyzip-demo-apb ServiceClass.v1alpha1.servicecatalog.k8s.io pyzip-demo-db-apb ServiceClass.v1alpha1.servicecatalog.k8s.io rhscl-mariadb-apb ServiceClass.v1alpha1.servicecatalog.k8s.io rhscl-postgresql-apb ServiceClass.v1alpha1.servicecatalog.k8s.io rocketchat-apb ServiceClass.v1alpha1.servicecatalog.k8s.io wordpress-ha-apb ServiceClass.v1alpha1.servicecatalog.k8s.io What are our plans to remedy this? -------------- next part -------------- An HTML attachment was scrubbed... URL: From cchase at redhat.com Fri Jul 14 15:17:17 2017 From: cchase at redhat.com (Christopher Chase) Date: Fri, 14 Jul 2017 11:17:17 -0400 Subject: [Ansible-service-broker] catasb - dev merged into master Message-ID: The "dev" branch of the catasb repository has been merged into the master branch. This means that all new development and pull requests on the catasb repo should target the master branch. This will be our current development environment with the latest stable code. In order to preserve the functionality for the 2017 summit demo, the summit2017 branch has been created. Anyone looking to show the original demo can checkout this branch and should be able to use it just as they had before on the master branch. Chris Chase -------------- next part -------------- An HTML attachment was scrubbed... URL: From ernelson at redhat.com Fri Jul 14 20:46:56 2017 From: ernelson at redhat.com (Erik Nelson) Date: Fri, 14 Jul 2017 16:46:56 -0400 Subject: [Ansible-service-broker] Filtered multi-registry support merged Message-ID: We merged a big feature branch into broker master for multiple registry and filtered APB support. I also just pushed an updated broker image to ansibleplaybookbundle and backed up the one that was there today. https://github.com/openshift/ansible-service-broker/pull/271 There was a brief time between the PR getting merged and the new broker image being available in Dockerhub where you potentially could have deployed to a broken state. John Kim was the lucky one who caught it :) Please raise any issues seen, otherwise, deploys from here on out should be stable. - Erik From jmatthew at redhat.com Tue Jul 18 15:03:38 2017 From: jmatthew at redhat.com (John Matthews) Date: Tue, 18 Jul 2017 11:03:38 -0400 Subject: [Ansible-service-broker] Automated Canary Builds Message-ID: All, After scrum today we discussed a means for creating automated builds for developer testing. (Relates to the CI work we planned for this sprint) We agreed on 2 basic types of builds for upstream: - Canary (matches latest git changes) - Latest (matches sanctioned releases we have created) We will use a label to denote the difference canary/latest We plan to address the 'canary' effort this sprint. Trello Card here: https://trello.com/c/CwyL8WnU Latest/Release automated builds are deferred, they will be more complicated to script as there is a dependency on building the RPM, waiting for repo metadata, then orchestrating image builds. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jmatthew at redhat.com Tue Jul 18 16:00:07 2017 From: jmatthew at redhat.com (John Matthews) Date: Tue, 18 Jul 2017 12:00:07 -0400 Subject: [Ansible-service-broker] PodPreset name limits to 63 chars, our new APB names are: "dockerhub-ansibleplaybookbundle-rhscl-postgresql-apb" Message-ID: Provision/Bind is broken with latest code upstream podpreset.admission.kubernetes.io/dockerhub-ansibleplaybookbundle-rhscl-postgresql-apb-3xcwz-2v5r4": name part must be no more than 63 characters -------------- next part -------------- An HTML attachment was scrubbed... URL: From jmatthew at redhat.com Wed Jul 19 02:33:09 2017 From: jmatthew at redhat.com (John Matthews) Date: Tue, 18 Jul 2017 22:33:09 -0400 (EDT) Subject: [Ansible-service-broker] =?utf-8?q?Release_Announcement=3A_Open_S?= =?utf-8?q?ervice_Broker_API_2=2E12_=E2=80=93_OpenShift_Blog?= Message-ID: https://blog.openshift.com/announcement-open-service-broker-api-2-12/ From jmatthew at redhat.com Wed Jul 19 11:41:01 2017 From: jmatthew at redhat.com (John Matthews) Date: Wed, 19 Jul 2017 07:41:01 -0400 Subject: [Ansible-service-broker] Moving fusor/catasb to run off of 3.6.0 rc builds Message-ID: We need to merge the below 2 PRs to restore functionality with fusor/catasb https://github.com/fusor/catasb/pull/92 https://github.com/fusor/catasb/pull/94 Yesterday origin updated 'master' to track kubernetes 1.7, the release 3.6 work is now in 'release-3.6' branch. We were using origin:latest in fusor/catasb, last night we started to see breakages. I'm recommending we move to v3.6.0-rc.0 for fusor/catasb and track the 3.6.0 rc builds as they are available. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jkim at redhat.com Thu Jul 20 12:42:58 2017 From: jkim at redhat.com (John Kim) Date: Thu, 20 Jul 2017 08:42:58 -0400 Subject: [Ansible-service-broker] Source-to-Image APB 's2i-apb' Screencast Message-ID: All, Below is a video showing building and launching of APB using the 's2i-apb' builder. https://youtu.be/ZhLvlpqHI8U V/R, John Kim -------------- next part -------------- An HTML attachment was scrubbed... URL: From jesusr at redhat.com Thu Jul 20 12:54:56 2017 From: jesusr at redhat.com (jesus m. rodriguez) Date: Thu, 20 Jul 2017 08:54:56 -0400 Subject: [Ansible-service-broker] PodPreset name limits to 63 chars, our new APB names are: "dockerhub-ansibleplaybookbundle-rhscl-postgresql-apb" In-Reply-To: References: Message-ID: <1500555296.11240.6.camel@redhat.com> On Tue, 2017-07-18 at 12:00 -0400, John Matthews wrote: > Provision/Bind is broken with latest code upstream > > podpreset.admission.kubernetes.io/dockerhub-ansibleplaybookbundle- > rhscl-postgresql-apb-3xcwz-2v5r4": > name part must be no more than 63 characters > _______________________________________________ > Ansible-service-broker mailing list > Ansible-service-broker at redhat.com > https://www.redhat.com/mailman/listinfo/ansible-service-broker It's a shame we couldn't have a shorter org name like apb. ansibleplaybookbundle is eating up 22 characters alone. would it be bad if we translated it on the backend? i.e. use apb but expand it to ansibleplaybookbundle? not entirely sure how that would work though. hrm. I picked that because apb was not a valid dockerhub org name. jesus -- jesus m. rodriguez | jesusr at redhat.com principal software engineer | irc: zeus red hat systems management | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +---------------------------------------------+ | "you will be assimilated; | | resistance is futile" | | -- Borg | +---------------------------------------------+ From tsanders at redhat.com Thu Jul 20 14:17:16 2017 From: tsanders at redhat.com (Todd Sanders) Date: Thu, 20 Jul 2017 14:17:16 +0000 Subject: [Ansible-service-broker] PodPreset name limits to 63 chars, our new APB names are: "dockerhub-ansibleplaybookbundle-rhscl-postgresql-apb" In-Reply-To: <1500555296.11240.6.camel@redhat.com> References: <1500555296.11240.6.camel@redhat.com> Message-ID: I don't think the answer here has to do with shortening the org name we are using. Seems like anyone could create an arbitrary org name that exceeds the 63 char limit. I think the broker needs to be able to encode these names to ensure we don't exceed. -Todd On Thu, Jul 20, 2017 at 8:55 AM jesus m. rodriguez wrote: > On Tue, 2017-07-18 at 12:00 -0400, John Matthews wrote: > > Provision/Bind is broken with latest code upstream > > > > podpreset.admission.kubernetes.io/dockerhub-ansibleplaybookbundle- > > rhscl-postgresql-apb-3xcwz-2v5r4": > > name part must be no more than 63 characters > > _______________________________________________ > > Ansible-service-broker mailing list > > Ansible-service-broker at redhat.com > > https://www.redhat.com/mailman/listinfo/ansible-service-broker > > It's a shame we couldn't have a shorter org name like apb. > ansibleplaybookbundle is eating up 22 characters alone. > > would it be bad if we translated it on the backend? i.e. use apb but > expand it to ansibleplaybookbundle? not entirely sure how that would > work though. hrm. I picked that because apb was not a valid dockerhub > org name. > > jesus > > -- > jesus m. rodriguez | jesusr at redhat.com > principal software engineer | irc: zeus > red hat systems management | 919.754.4413 (w) > rhce # 805008586930012 | 919.623.0080 (c) > +---------------------------------------------+ > | "you will be assimilated; | > | resistance is futile" | > | -- Borg | > +---------------------------------------------+ > > _______________________________________________ > Ansible-service-broker mailing list > Ansible-service-broker at redhat.com > https://www.redhat.com/mailman/listinfo/ansible-service-broker > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ernelson at redhat.com Fri Jul 21 15:25:33 2017 From: ernelson at redhat.com (Erik Nelson) Date: Fri, 21 Jul 2017 11:25:33 -0400 Subject: [Ansible-service-broker] Plans proposal Message-ID: Added a PR with proposed changes to support multiple plans, looking for feedback. The proposed change will require all existing APBs to be updated for compliance. I've got a patch written for the broker that will actually deploy the example apb.yml. I was able to provision/bind each plan from the UI; plans and their parameters are displaying correctly. Going to update pep's multi-plan mysql APB and test today. https://github.com/openshift/ansible-service-broker/pull/294 From jmatthew at redhat.com Fri Jul 21 17:33:44 2017 From: jmatthew at redhat.com (John Matthews) Date: Fri, 21 Jul 2017 13:33:44 -0400 Subject: [Ansible-service-broker] Minimal script to get oc cluster up working with service catalog and ansible service broker Message-ID: FYI. I put this together to help show minimal setup for using ansible service broker. This may be useful for CI testing as it takes ~90 seconds to bring up an environment. https://gist.github.com/jwmatthews/3c8a2844970cb350d43d91d37470e7d6 -------------- next part -------------- An HTML attachment was scrubbed... URL: From rhallise at redhat.com Fri Jul 21 18:23:45 2017 From: rhallise at redhat.com (Ryan Hallisey) Date: Fri, 21 Jul 2017 14:23:45 -0400 Subject: [Ansible-service-broker] Minimal script to get oc cluster up working with service catalog and ansible service broker In-Reply-To: References: Message-ID: Might be worth documenting this somewhere in the asb repo. Something like a quickstart? or minimal setup script? -Ryan On Fri, Jul 21, 2017 at 1:33 PM, John Matthews wrote: > FYI. > > I put this together to help show minimal setup for using ansible service > broker. > This may be useful for CI testing as it takes ~90 seconds to bring up an > environment. > > https://gist.github.com/jwmatthews/3c8a2844970cb350d43d91d37470e7d6 > > _______________________________________________ > Ansible-service-broker mailing list > Ansible-service-broker at redhat.com > https://www.redhat.com/mailman/listinfo/ansible-service-broker > From rhallise at redhat.com Fri Jul 21 18:44:00 2017 From: rhallise at redhat.com (Ryan Hallisey) Date: Fri, 21 Jul 2017 14:44:00 -0400 Subject: [Ansible-service-broker] broker latest tag isn't using the latest rpm Message-ID: Hey folks, There are 2 independent triggers we use: 1) copr (rpm build trigger) 2) dockerhub (automatic container builds). When a new PR merges, copr builds a new rpm and the broker image is build. Since these jobs are independent, it's possible the docker container could be build and tagged before the rpm has been built. This can result in the ansible-service-broker:latest image being one patch behind ansible-service-broker:canary. A possible fix would be to trigger the build from copr so we only have one trigger in place. But that's assuming copr can perform a curl operation as part of the build process. And I don't know if it can. I'm open to other possible solutions. But in the meantime, if there's an issue with an image switch to the canary tag. Thanks, -Ryan From jmatthew at redhat.com Fri Jul 21 19:34:02 2017 From: jmatthew at redhat.com (John Matthews) Date: Fri, 21 Jul 2017 15:34:02 -0400 Subject: [Ansible-service-broker] Minimal script to get oc cluster up working with service catalog and ansible service broker In-Reply-To: References: Message-ID: Created this PR to add the script and update the README. https://github.com/openshift/ansible-service-broker/pull/296 I put the script at the project root, I thought it might be confusing putting it in 'scripts', since all the files in 'scripts' are more developer focused. On Fri, Jul 21, 2017 at 2:23 PM, Ryan Hallisey wrote: > Might be worth documenting this somewhere in the asb repo. Something > like a quickstart? or minimal setup script? > > -Ryan > > On Fri, Jul 21, 2017 at 1:33 PM, John Matthews > wrote: > > FYI. > > > > I put this together to help show minimal setup for using ansible service > > broker. > > This may be useful for CI testing as it takes ~90 seconds to bring up an > > environment. > > > > https://gist.github.com/jwmatthews/3c8a2844970cb350d43d91d37470e7d6 > > > > _______________________________________________ > > Ansible-service-broker mailing list > > Ansible-service-broker at redhat.com > > https://www.redhat.com/mailman/listinfo/ansible-service-broker > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jesusr at redhat.com Fri Jul 21 21:13:31 2017 From: jesusr at redhat.com (jesus m. rodriguez) Date: Fri, 21 Jul 2017 17:13:31 -0400 Subject: [Ansible-service-broker] Minimal script to get oc cluster up working with service catalog and ansible service broker In-Reply-To: References: Message-ID: <1500671611.18385.5.camel@redhat.com> On Fri, 2017-07-21 at 15:34 -0400, John Matthews wrote: > Created this PR to add the script and update the README. > https://github.com/openshift/ansible-service-broker/pull/296 > > I put the script at the project root, I thought it might be confusing > putting it in 'scripts', since all the files in 'scripts' are more > developer focused. > HA! that was my first comment when I clicked the PR link. I'd rather keep all the scripts in the scripts directory. There aren't any scripts in the root dir right now. We have the readme, Makefile, rpm spec, and glide. Anyone cloning this repo will likely be trying to develop on it. If they are visiting the repo and reading the documentation, they will see the link to the script living in scripts. Actually they probably won't even notice where it is, since they'll just click the link. We can create a bin/ directory if we want to make it stand out, but honestly I think scripts will be fine. -1 to root. jesus -- jesus m. rodriguez | jesusr at redhat.com principal software engineer | irc: zeus red hat systems management | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +---------------------------------------------+ | "you will be assimilated; | | resistance is futile" | | -- Borg | +---------------------------------------------+ From jmatthew at redhat.com Mon Jul 24 16:20:52 2017 From: jmatthew at redhat.com (John Matthews) Date: Mon, 24 Jul 2017 12:20:52 -0400 Subject: [Ansible-service-broker] FYI: ServiceCatalog is changing some resource names to have ServiceCatalog prefix Message-ID: Trello card for us to investigate what impacts this has to broker https://trello.com/c/azAR8uU5 Associated PR: https://github.com/kubernetes-incubator/service-catalog/pull/1054 -------------- next part -------------- An HTML attachment was scrubbed... URL: From ernelson at redhat.com Tue Jul 25 02:27:25 2017 From: ernelson at redhat.com (Erik Nelson) Date: Mon, 24 Jul 2017 22:27:25 -0400 Subject: [Ansible-service-broker] Multi-plan support incoming Message-ID: Hey folks, We have multi-plan support PRs ready to merge after a round of regression testing today. It is a *breaking change* to existing APBs; the broker will not support APBs prior to this change. We have a feature branch in apb-examples that we're planning on merging to update all outstanding upstream APBs atomically. Wanted to send out this mail to alert folks to the change, it's probably a good idea to clean your local image cache to ensure you pull a new broker image and all new APB images. Also, if anyone objects to this, please yell at me. I'm planning on merging it all around 1pm tomorrow. - Erik From ernelson at redhat.com Tue Jul 25 02:57:27 2017 From: ernelson at redhat.com (Erik Nelson) Date: Mon, 24 Jul 2017 22:57:27 -0400 Subject: [Ansible-service-broker] Fwd: Multi-plan support incoming In-Reply-To: References: Message-ID: Forgot the PRs: https://github.com/openshift/ansible-service-broker/pull/298 https://github.com/fusor/apb-examples/pull/96 Realized the broker PR requires some extensive test changes as a result of my changes, so it will probably delay things until the end of the day :) ---------- Forwarded message ---------- From: Erik Nelson Date: Mon, Jul 24, 2017 at 10:27 PM Subject: Multi-plan support incoming To: ansible-service-broker at redhat.com Hey folks, We have multi-plan support PRs ready to merge after a round of regression testing today. It is a *breaking change* to existing APBs; the broker will not support APBs prior to this change. We have a feature branch in apb-examples that we're planning on merging to update all outstanding upstream APBs atomically. Wanted to send out this mail to alert folks to the change, it's probably a good idea to clean your local image cache to ensure you pull a new broker image and all new APB images. Also, if anyone objects to this, please yell at me. I'm planning on merging it all around 1pm tomorrow. - Erik From rhallise at redhat.com Wed Jul 26 21:08:35 2017 From: rhallise at redhat.com (Ryan Hallisey) Date: Wed, 26 Jul 2017 17:08:35 -0400 Subject: [Ansible-service-broker] CI Job Message-ID: Folks, The CI job is green: https://github.com/openshift/ansible-service-broker/pull/291 . This CI job will do the following: - Setup openshift w/ catasb - Setup the catalog w/ catasb - Build the broker with make build-image - Deploy the broker with make deploy - Provision mediawiki through the catalog - Provision postgresql through the catalog - Create a Binding of mediawiki and postgresql - Restart the mediawiki pod to pickup the podpreset - Curl the mediawiki address and check if bind succeded Things needed in the future: - Investigate a catalog bug when binding hanging forever when requested during a provision - fix deprovision - make ci - local testing - CI framework to easily add new apbs to the gate Sincerely, -Ryan From jmatthew at redhat.com Wed Jul 26 21:38:54 2017 From: jmatthew at redhat.com (John Matthews) Date: Wed, 26 Jul 2017 17:38:54 -0400 Subject: [Ansible-service-broker] oc cluster up --servicecatalog and learning what it's doing Message-ID: I'm tracking through how --servicecatalog works in oc cluster up to help debug some issues with catasb running downstream builds. Thought I'd share some of the pointers so others can look if they are curious. Basic concept is that oc cluster up will: - Setup an API Group for the service catalog api-server - Deploy a template to launch 2 pods: api-server controller-manager Both of those pods use the same image, but run different commands. controller-manager: runs 'controller-manager' apiserver: runs 'apiserver' Hence the single image: openshift/origin-service-catalog for both pods Where in past we had apiserver and controller-manager images. To look at the template oc cluster up is deploying to bring up the service-catalog you can run: $ oc export template service-catalog --namespace=openshift-infra In near future, we plan to submit a PR for the deployment of ansible service broker when '--service-catalog' is specified. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ernelson at redhat.com Fri Jul 28 19:21:24 2017 From: ernelson at redhat.com (Erik Nelson) Date: Fri, 28 Jul 2017 15:21:24 -0400 Subject: [Ansible-service-broker] Multi-plan support merged In-Reply-To: References: Message-ID: Hey folks, We just merged Multi-plan support to broker master and apb-examples, so new images should be pushed out by CI some point soon. Once that's finished, be sure you are running the new broker image and apbs for testing; a new broker cannot deploy old APBs and vice versa. Please let me know if any problems are picked up. I'll be testing with vanilla catasb as soon as the new images are available. - Erik -------------- next part -------------- An HTML attachment was scrubbed... URL: From jmatthew at redhat.com Fri Jul 28 19:37:50 2017 From: jmatthew at redhat.com (John Matthews) Date: Fri, 28 Jul 2017 15:37:50 -0400 Subject: [Ansible-service-broker] =?utf-8?q?OpenShift_3=2E6_=E2=80=93_Rele?= =?utf-8?q?ase_Candidate_=28A_Hands-On=29?= Message-ID: https://developers.redhat.com/blog/2017/07/28/openshift-3-6-a-hands-on-the-release-candidate/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From rhallise at redhat.com Fri Jul 28 19:48:38 2017 From: rhallise at redhat.com (Ryan Hallisey) Date: Fri, 28 Jul 2017 15:48:38 -0400 Subject: [Ansible-service-broker] Multi-plan support merged In-Reply-To: References: Message-ID: You can try out the local CI patch for testing: https://github.com/openshift/ansible-service-broker/pull/317 `make ci` will imitate the gate testing. -Ryan On Fri, Jul 28, 2017 at 3:21 PM, Erik Nelson wrote: > Hey folks, > > We just merged Multi-plan support to broker master and apb-examples, so new > images should be pushed out by CI some point soon. Once that's finished, be > sure you are running the new broker image and apbs for testing; a new broker > cannot deploy old APBs and vice versa. > > Please let me know if any problems are picked up. I'll be testing with > vanilla catasb as soon as the new images are available. > > - Erik > > _______________________________________________ > Ansible-service-broker mailing list > Ansible-service-broker at redhat.com > https://www.redhat.com/mailman/listinfo/ansible-service-broker > From ernelson at redhat.com Fri Jul 28 20:37:44 2017 From: ernelson at redhat.com (Erik Nelson) Date: Fri, 28 Jul 2017 16:37:44 -0400 Subject: [Ansible-service-broker] Multi-plan support merged In-Reply-To: References: Message-ID: So I've confirmed that CI only updated the canary images, which makes sense since the latest images have a dependency on the RPMs getting rebuilt. Is this expected with the current CI setup (I assume it is). What do we need to do to trigger a full rebuild and make sure "latest" APBs also get the changes? This is a bit of a problem, because the broker and all our environments are configured to deploy from latest, and there isn't an easy way ATM to configure the broker to deploy tagged APBs (canary). I'd like to add this ability to the broker. Basically master is broken right now until the APBs tagged latest can get rebuilt. Am I understanding this correctly? Is there a way we can prevent this in the future? On Fri, Jul 28, 2017 at 3:48 PM, Ryan Hallisey wrote: > You can try out the local CI patch for testing: > https://github.com/openshift/ansible-service-broker/pull/317 > `make ci` will imitate the gate testing. > > -Ryan > > On Fri, Jul 28, 2017 at 3:21 PM, Erik Nelson wrote: >> Hey folks, >> >> We just merged Multi-plan support to broker master and apb-examples, so new >> images should be pushed out by CI some point soon. Once that's finished, be >> sure you are running the new broker image and apbs for testing; a new broker >> cannot deploy old APBs and vice versa. >> >> Please let me know if any problems are picked up. I'll be testing with >> vanilla catasb as soon as the new images are available. >> >> - Erik >> >> _______________________________________________ >> Ansible-service-broker mailing list >> Ansible-service-broker at redhat.com >> https://www.redhat.com/mailman/listinfo/ansible-service-broker >> From rhallise at redhat.com Fri Jul 28 22:27:42 2017 From: rhallise at redhat.com (Ryan Hallisey) Date: Fri, 28 Jul 2017 18:27:42 -0400 Subject: [Ansible-service-broker] Multi-plan support merged In-Reply-To: References: Message-ID: I agree we should add the ability to easily deploy from any tag. The latest tag currently trails canary by about ~1 hour. Once the rpm gets built, latest gets updated. I attached a screen shot of dockerhub illustrating this. Master should be working now since latest has been rebuilt with the newest rpm. -Ryan On Fri, Jul 28, 2017 at 4:37 PM, Erik Nelson wrote: > So I've confirmed that CI only updated the canary images, which makes > sense since the latest images have a dependency on the RPMs getting > rebuilt. Is this expected with the current CI setup (I assume it is). > What do we need to do to trigger a full rebuild and make sure "latest" > APBs also get the changes? > > This is a bit of a problem, because the broker and all our > environments are configured to deploy from latest, and there isn't an > easy way ATM to configure the broker to deploy tagged APBs (canary). > I'd like to add this ability to the broker. > > Basically master is broken right now until the APBs tagged latest can > get rebuilt. Am I understanding this correctly? Is there a way we can > prevent this in the future? > > On Fri, Jul 28, 2017 at 3:48 PM, Ryan Hallisey wrote: >> You can try out the local CI patch for testing: >> https://github.com/openshift/ansible-service-broker/pull/317 >> `make ci` will imitate the gate testing. >> >> -Ryan >> >> On Fri, Jul 28, 2017 at 3:21 PM, Erik Nelson wrote: >>> Hey folks, >>> >>> We just merged Multi-plan support to broker master and apb-examples, so new >>> images should be pushed out by CI some point soon. Once that's finished, be >>> sure you are running the new broker image and apbs for testing; a new broker >>> cannot deploy old APBs and vice versa. >>> >>> Please let me know if any problems are picked up. I'll be testing with >>> vanilla catasb as soon as the new images are available. >>> >>> - Erik >>> >>> _______________________________________________ >>> Ansible-service-broker mailing list >>> Ansible-service-broker at redhat.com >>> https://www.redhat.com/mailman/listinfo/ansible-service-broker >>> -------------- next part -------------- A non-text attachment was scrubbed... Name: autobuilds.png Type: image/png Size: 33787 bytes Desc: not available URL: