[Ansible-service-broker] CRD Client for the Service Broker

[Shawn Hurley]

Hello All,

I am expecting to call the generated client https://github.com/automationbroker/broker-client-go <https://github.com/automationbroker/broker-client-go> 

Does anyone think the name should be different? I don’t have strong opinions but the name is attempting to implicate that it is similar to the client-go but specifically for the broker. I could see maybe just client-go because it is in the automation broker repo?

Thanks,

Shawn Hurley

> On Feb 20, 2018, at 2:14 PM, Ryan Hallisey <rhallise at redhat.com> wrote:
> 
> Sounds good to me Shawn.  This is a good step towards being vendorable.
> 
> Looks like the git org https://github.com/AutomationBroker <https://github.com/AutomationBroker> already exists.  Does someone here own it? It looks abandoned.  Maybe we can ask git to delete it.
> 
> -Ryan
> 
> On Tue, Feb 20, 2018 at 2:01 PM, Shawn Hurley <shurley at redhat.com <mailto:shurley at redhat.com>> wrote:
> Yes that is correct about the venerable dependency.
> An example of what this would look like is here: https://github.com/openshift-evangelists/crd-code-generation <https://github.com/openshift-evangelists/crd-code-generation>. 
> 
> In a nut shell the client is like every other client-go for k8s resources. it has listers/informers and the interface/impl for crud operations. 
> 
> Thanks,
> 
> Shawn 
> 
>> On Feb 20, 2018, at 1:57 PM, Ryan Hallisey <rhallise at redhat.com <mailto:rhallise at redhat.com>> wrote:
>> 
>> Would the broker-client-go be essentially a vendorable dependency like the client-go package in kubernetes? Do I understand that correctly? At a high level, what would be in the broker-client-go?
>> 
>> -Ryan
>> 
>> On Tue, Feb 20, 2018 at 1:43 PM, cbrookes at redhat.com <mailto:cbrookes at redhat.com> <cbrookes at redhat.com <mailto:cbrookes at redhat.com>> wrote:
>> I think that is a great way of doing it! We use the generators for our mobile crd types and it is working well for us. I would really like if the service catalog had taken the approach of a separate repo for the client maybe we could suggest it?
>> 
>> Craig
>> 
>> On 20 Feb 2018, at 18:33, Shawn Hurley <shurley at redhat.com <mailto:shurley at redhat.com>> wrote:
>> 
>>> Hello All,
>>> 
>>> I wanted to send out a note to make sure that everyone was ok with the approach for the k8s like client for broker CRDs.
>>> 
>>> I was thinking that we would create a new repo, I assume we need a new org (automationbroker or something similar), and this would contain the broker-client-go.
>>> 
>>> The client would be generated using the k8s generate client scripts and code. Here is a blog post about how this works for some context: https://blog.openshift.com/kubernetes-deep-dive-code-generation-customresources/ <https://blog.openshift.com/kubernetes-deep-dive-code-generation-customresources/>
>>> 
>>> This client then would be added to the broker through glide/dep. 
>>> 
>>> If the above is agreeable some help/guidence on next steps for making the new repo would be appreciated.
>>> 
>>> Thanks,
>>> 
>>> Shawn Hurley
>>> 
>>> _______________________________________________
>>> Ansible-service-broker mailing list
>>> Ansible-service-broker at redhat.com <mailto:Ansible-service-broker at redhat.com>
>>> https://www.redhat.com/mailman/listinfo/ansible-service-broker <https://www.redhat.com/mailman/listinfo/ansible-service-broker>
>> 
>> _______________________________________________
>> Ansible-service-broker mailing list
>> Ansible-service-broker at redhat.com <mailto:Ansible-service-broker at redhat.com>
>> https://www.redhat.com/mailman/listinfo/ansible-service-broker <https://www.redhat.com/mailman/listinfo/ansible-service-broker>
>> 
>> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/ansible-service-broker/attachments/20180222/581e7842/attachment.htm>