<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:D="DAV:" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:st1="urn:schemas-microsoft-com:office:smarttags" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv=Content-Type content="text/html; charset=gb2312"> <meta name=Generator content="Microsoft Word 11 (filtered medium)"> <o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags" name="chmetcnv"/> <o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags" name="PersonName"/>  <style>  </style> </head> <body lang=ZH-CN link=blue vlink=purple style='text-justify-trim:punctuation'> <div class=Section1 style='layout-grid:15.6pt'> Hi Heinz,<o:p></o:p> Could you please review the following issue? <o:p></o:p> Looking forward to your reply!<o:p></o:p> <o:p> </o:p> Thanks!<o:p></o:p> conke<o:p></o:p> <o:p> </o:p> <div> <div class=MsoNormal align=center style='text-align:center'> <hr size=2 width="100%" align=center tabindex=-1> </div> From: Conke Hu Sent: 2006年9月29日 20:38 To: '<st1:PersonName w:st="on">Mauelshagen@RedHat.com</st1:PersonName>' Cc: '<st1:PersonName w:st="on">g.hoogewerf@gmail.com</st1:PersonName>' Subject: a dmraid bug on Promise RAID<o:p></o:p> </div> <o:p> </o:p> Hi,<o:p></o:p> There is bug in pdc.c (lib/format/ataraid/pdc.c). when you activate the promise software RAID, you will get the error messages shown in the attached screenshot.<o:p></o:p> We’ve found the root cause. Firstly let’s take a look at struct pdc:<o:p></o:p> struct pdc {<o:p></o:p> uint8_t promise_id[PDC_ID_LENGTH]; /* 0x00 - 0x17 */<o:p></o:p> uint32_t unknown_0; /* 0x18 - 0x1B */<o:p></o:p> uint32_t magic_0; /* 0x<st1:chmetcnv UnitName="C" SourceValue="1" HasSpace="False" Negative="False" NumberType="1" TCSC="0" w:st="on">1C</st1:chmetcnv> - 0x<st1:chmetcnv UnitName="F" SourceValue="1" HasSpace="False" Negative="False" NumberType="1" TCSC="0" w:st="on">1F</st1:chmetcnv> */<o:p></o:p> According to the Promise engineer, the value set at offset 0x1C is not a magic number, but records the RAID engine version. So when dmraid executes the following code (lib/format/ataraid/pdc.c):<o:p></o:p> if (pdc->magic_0 == pdc->raid.magic_0 &&<o:p></o:p> pdc->raid.total_disks &&<o:p></o:p> pdc->raid.total_disks < PDC_MAXDISKS)<o:p></o:p> return 1;<o:p></o:p> it always returns 1 since pdc->magic_0 never equals pdc->raid.magic_0 ! <o:p></o:p> To fix this bug, dmraid source code only needs to ignore checking magic_0, modified to the following:<o:p></o:p> if ( pdc->raid.total_disks &&<o:p></o:p> pdc->raid.total_disks < PDC_MAXDISKS)<o:p></o:p> return 1;<o:p></o:p> I have tested this modification and it is safe to delete “pdc->magic_0 == pdc->raid.magic_0”.<o:p></o:p> Could you please do this change in next dmraid version?<o:p></o:p> <o:p> </o:p> Thanks!<o:p></o:p> Conke<o:p></o:p> <o:p> </o:p> </div> </body> </html>