[augeas-devel] Re: [PATCH 0 of 2] Improve regexps in dput.aug and php.aug

[David Lutterkort]

On Tue, 2008-07-29 at 11:52 +0200, Raphael Pinson wrote:
> Improve regexps in dput.aug and php.aug
> Gather regexps before calling IniFile.entry. Call IniFile.entry only once.
> This fixes most of the slowlyness of php.aug

I still have trouble with the patch 'Rewrite dput.aug using inifile.aug'
- the test_dput.aug still fails for me. It seems the problem is the line

        post_upload_command = /usr/bin/mini-dinstall --batch
        
in the ftp-master section - I think the inifile lens does not like
spaces in the value. When I run the tests through augparse, it reports

        Test run encountered exception:
        lenses/tests/test_dput.aug:59.8-.25:exception: Get did not match entire input
            Error encountered here (1202 characters into string)
            <nd = /path/to/some/script\n#\n|=|>                           
        
Can you just resend these two patches and the following as one patch
series:

      * Fix empty comments in INI file
      * Allow spaces in titles
      * Rewrite dput.aug using inifile.aug

This is the order in which I applied them.

David