[augeas-devel] span in Java API?

[Francis Giraldeau]

On Mon, 2011-07-25 at 18:18 -0700, Alex Cruise wrote:
> On Mon, Jul 25, 2011 at 6:03 PM, Alex Cruise <alex at cluonflux.com>
> wrote:
>         On Mon, Jul 25, 2011 at 4:32 PM, David Lutterkort
>         <lutter at redhat.com> wrote:
>                 On Mon, 2011-07-25 at 16:00 -0700, Alex Cruise wrote:
>                 > I'm using the Java API successfully, but I note that
>                 the `span` command
>                 > isn't supported there.  Would it be extremely
>                 difficult to add it?
> 
> Also
> https://github.com/acruise/java-augeas/commit/59821001faa8635b61f680eb405efaaca6b430d6


Thanks very much for this addon. I took a look to it and it seems good.
I just changed few things

* Adding flag AUG_ENABLE_SPAN to enable span on load
* Checking for null filename to avoid null pointer exception
* Adding NO_SPAN error code matching the API
* Adding tests for all this 

As a side note, I had to add junit4.jar on the classpath for tests
because this is the default archive name on deb distros. 

Here are the patches. I also did a merge of all those patches and your
own work. Let me know if you find additional issues. Maybe it should be
a good idea to bump augeas-java binding version number for this?

Have a nice day, 

Francis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-correct-jar-name-under-debian.patch
Type: text/x-patch
Size: 1114 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20110726/38009dbb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Adding-span-enable-flag.patch
Type: text/x-patch
Size: 929 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20110726/38009dbb/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Adding-span-error-code.patch
Type: text/x-patch
Size: 1070 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20110726/38009dbb/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Avoid-null-pointer-exception-when-string-is-null.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20110726/38009dbb/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Test-span-on-load-and-span-error-code.patch
Type: text/x-patch
Size: 1675 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20110726/38009dbb/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ALL-span-support-in-Java-bindings.patch
Type: text/x-patch
Size: 10055 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20110726/38009dbb/attachment-0005.bin>