<div dir="ltr"><br><br><div class="Ih2E3d">On Fri, Jul 25, 2008 at 9:01 PM, David Lutterkort <span dir="ltr"><<a href="mailto:dlutter@redhat.com" target="_blank">dlutter@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Fri, 2008-07-25 at 13:54 +0200, Raphael Pinson wrote:<br>
> # HG changeset patch<br>
> # User Raphael Pinson <<a href="mailto:raphink@gmail.com" target="_blank">raphink@gmail.com</a>><br>
> # Date 1216986841 -7200<br>
> # Node ID f1ade288e3ea62d5799229c2a8610f6e1b4e86b2<br>
> # Parent f575bc6e9cbb2a04037800d5a75a75bf84a62ed6<br>
> Rewrite dput.aug using inifile.aug<br>
> Add a few keywords from man <a href="http://dput.cf/" target="_blank">dput.cf</a><br>
> Fix test file after rewrite<br>
<br>
</div>I get a test failure after applying this patch:<br>
<br>
galia:[7071] augeas>./src/augparse -I lenses/ lenses/tests/test_dput.aug<br>
Test run encountered exception:<br>
lenses/tests/test_dput.aug:59.8-.25:exception: Get did not match entire input<br>
Error encountered here (1202 characters into string)<br>
<nd = /path/to/some/script\n#\n|=|><br>
<br>
Tree generated so far:<br>
... snipped ...<br>
</blockquote></div><div><br><br>Ah. Did you apply the inifile patches before that?<br> <br><br></div><div class="Ih2E3d"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><br>
<br>
> diff -r f575bc6e9cbb -r f1ade288e3ea lenses/dput.aug<br>
> --- a/lenses/dput.aug Fri Jul 25 13:46:13 2008 +0200<br>
> +++ b/lenses/dput.aug Fri Jul 25 13:54:01 2008 +0200<br>
> @@ -1,60 +1,33 @@<br>
> (* Dput module for Augeas *)<br>
> (* Author: Raphael Pinson <<a href="mailto:raphink@gmail.com" target="_blank">raphink@gmail.com</a>> *)<br>
> (* *)<br>
> -(* Status: most settings supported *)<br>
><br>
><br>
> module Dput =<br>
> autoload xfm<br>
><br>
> + let setting = IniFile.entry "allow_non-us_software"<br>
> + | IniFile.entry "allow_unsigned_uploads"<br>
> + | IniFile.entry "check_version"<br>
> + | IniFile.entry "default_host_main"<br>
> + | IniFile.entry "default_host_non-us"<br>
<br>
</div>Performance-wise, the lens would be much faster if you wrote this as<br>
<br>
let setting_re = "allow_non-us_software"<br>
| "allow_unsigned_uploads"<br>
| "check_version"<br>
| "default_host_main"<br>
| "default_host_non-us"<br>
| ...<br>
<br>
let setting = IniFile.entry setting_re<br>
<br>
<br>
It leads to much more compact data structurs internally.</blockquote></div><br><br>That's good to know. It might solve some performance issues with php.aug, too.<br><br><br>Raphael<br></div>