<div dir="ltr">Hi Sean, Thanks for the patch, it looks very nice. I based the initial lens on the options I usually use, so I'm not surprised it's lacking fields. However, list_to_eol is not used as of now. I think it would be actually better to use it instead of defining tabooext separately. So you would have let list_item = [ sep_spc . key /[^\/+,# \n\t{}]+/ ] let list_to_eol (kw:string) (indent:string) = [ del /[ \t]*/ indent . key kw . ( sep_spc . store /\+/ )? . list_item+ . eol ] let attrs (indent:string) = ... | list_to_eol "tabooext" indent | list_to_eol "compressoptions" indent This way, you don't have to redefine a specific field for tabooext. That said, the checks are less stricts on "compressoptions". It would also be nice to try and limit lines to 80 (or preferably 75) characters and begin to document the code (with NaturalDocs, I might begin to do that for all lenses when I get some time). Raphael <div class="gmail_quote">On Sun, Sep 28, 2008 at 2:50 AM, Sean E. Millichamp <<a href="mailto:sean@bruenor.org">sean@bruenor.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">On Sat, 2008-09-27 at 09:45 +0200, Dominique Dumont wrote: > From what I've understood, Augeas cannot decide which lenses will > apply to 'tabooext + A'. </div><div class="Ih2E3d">> I do not know exactly logrotate syntax, but you may want to exclude > the '+' character from list_item: > > let list_item = [ sep_spc . key /[^\/,# \n\t{}\+]+/ ] </div>Thanks Dominique, that was it exactly. I have re-attached the patch. This one should be ready to go. Sean _______________________________________________ augeas-devel mailing list <a href="mailto:augeas-devel@redhat.com">augeas-devel@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/augeas-devel" target="_blank">https://www.redhat.com/mailman/listinfo/augeas-devel</a> </blockquote></div> </div>