<div dir="ltr"><a href="https://github.com/avocado-framework/avocado-vt/pull/668">https://github.com/avocado-framework/avocado-vt/pull/668</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 18, 2016 at 2:39 PM, Cleber Rosa <span dir="ltr"><<a href="mailto:crosa@redhat.com" target="_blank">crosa@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 08/18/2016 06:50 AM, Andrei Stepanov wrote:<br>
> Hello.<br>
><br>
<br>
Hi Andrei,<br>
<div><div class="h5"><br>
> We have now broken cartesian_config.py.<br>
><br>
> It was broken by:<br>
><br>
> commit 81c6ce860b2f625ec31533779c479c<wbr>f9bf14af38<br>
> Author: Xu Tian <<a href="mailto:xutian@redhat.com">xutian@redhat.com</a>><br>
> Date:   Mon May 23 15:10:48 2016 +0800<br>
><br>
>     virttest.cartesian_config: enable postfix_parse<br>
><br>
>     postfix string '_fixed', '_max' and '_min' doesn't work, because<br>
>     'postfix_parse' not call in get_dict function. this commit enable<br>
>     it, because tp-qemu tests need these params.<br>
><br>
>     Signed-off-by: Xu Tian <<a href="mailto:xutian@redhat.com">xutian@redhat.com</a>><br>
><br>
><br>
><br>
> The error is:<br>
><br>
> [root@localhost cfg]# cartesian_config.py tests.cfg<br>
> Traceback (most recent call last):<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 2301, in <module><br>
>     print_dicts(options, dicts)<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 2187, in print_dicts<br>
>     print_dicts_default(options, dicts)<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 2160, in print_dicts_def<br>
> ault<br>
>     for count, dic in enumerate(dicts):<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 1939, in get_dicts<br>
>     for d in self.get_dicts_plain(node, ctx, content, shortname, dep):<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 2145, in get_dicts_plain<br>
>     for d in self.get_dicts(n, ctx, new_content, shortname, dep):<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 1939, in get_dicts<br>
>     for d in self.get_dicts_plain(node, ctx, content, shortname, dep):<br>
><br>
> .....<br>
><br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 2145, in get_dicts_plain<br>
>     for d in self.get_dicts(n, ctx, new_content, shortname, dep):<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 1942, in get_dicts<br>
>     postfix_parse(d)<br>
>   File "/mnt/tests/spice/qe-tests/<wbr>avocado-vt/virttest/cartesian_<wbr>config.py",<br>
> line 2244, in postfix_parse<br>
>     if key.endswith("_max"):<br>
> AttributeError: 'tuple' object has no attribute 'endswith'<br>
><br>
><br>
> If I do:<br>
><br>
> git revert 81c6ce860b2f625ec31533779c479c<wbr>f9bf14af38<br>
><br>
> than I do not have such error. Please fix.<br>
><br>
<br>
</div></div>Please propose the revert as a PR.  Xu and the others Avocado-VT<br>
maintainers can review, comment and (optionally) apply your proposal.<br>
<br>
Thanks!<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Cleber Rosa<br>
[ Sr Software Engineer - Virtualization Team - Red Hat ]<br>
[ Avocado Test Framework - <a href="http://avocado-framework.github.io" rel="noreferrer" target="_blank">avocado-framework.github.io</a> ]<br>
</font></span></blockquote></div><br></div>