[Cluster-devel] Re: [GFS2] Fix crc32 calculation in recovery.c [8/70]

[Steven Whitehouse]

Hi,

On Sat, 2006-12-02 at 09:40 +0100, Jan Engelhardt wrote:
> >Commit "[GFS2] split and annotate gfs2_log_head" resulted in an incorrect
> >checksum calculation for log headers. This patch corrects the
> >problem without resorting to copying the whole log header as
> >the previous code used to.
> >
> >Cc: Al Viro <viro at zeniv.linux.org.uk>
> >Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>
> >---
> > fs/gfs2/recovery.c |    9 +++++----
> > 1 files changed, 5 insertions(+), 4 deletions(-)
> >
> >diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> >index 4478162..4acf238 100644
> >--- a/fs/gfs2/recovery.c
> >+++ b/fs/gfs2/recovery.c
> >@@ -136,6 +136,7 @@ static int get_log_header(struct gfs2_jd
> > {
> > 	struct buffer_head *bh;
> > 	struct gfs2_log_header_host lh;
> >+static const u32 nothing = 0;
> > 	u32 hash;
> > 	int error;
> > 
> 
> At least indent it.
> 

I've had a private email from someone pointing out the same thing. It
was not intended to emphasise the fact that it is static, I'm not sure
if thats the "right thing" or not, but either way, it doesn't actually
need to be static, so that I've agreed that I'll remove the static and
just leave it as const and fix the indenting at the same time,

Steve.