[Cluster-devel] [DLM] fix oops in kref_put when removing a lockspace [5/5]
Steven Whitehouse
swhiteho at redhat.com
Mon Nov 6 11:08:17 UTC 2006
>From e2de7f565521a76fbbb927f701c5a1d381c71a93 Mon Sep 17 00:00:00 2001
From: Patrick Caulfield <pcaulfie at redhat.com>
Date: Mon, 6 Nov 2006 08:53:28 +0000
Subject: [PATCH] [DLM] fix oops in kref_put when removing a lockspace
Now that the lockspace struct is freed when the last sysfs object is released
this patch prevents use of that lockspace by sysfs. We attempt to re-get the
lockspace from the lockspace list and fail the request if it has been removed.
Signed-Off-By: Patrick Caulfield <pcaulfie at redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>
---
fs/dlm/lockspace.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index 499ee11..f8842ca 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -43,6 +43,10 @@ static ssize_t dlm_control_store(struct
ssize_t ret = len;
int n = simple_strtol(buf, NULL, 0);
+ ls = dlm_find_lockspace_local(ls->ls_local_handle);
+ if (!ls)
+ return -EINVAL;
+
switch (n) {
case 0:
dlm_ls_stop(ls);
@@ -53,6 +57,7 @@ static ssize_t dlm_control_store(struct
default:
ret = -EINVAL;
}
+ dlm_put_lockspace(ls);
return ret;
}
--
1.4.1
More information about the Cluster-devel
mailing list