[Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving
Patrick Caulfield
pcaulfie at redhat.com
Tue Mar 13 17:34:40 UTC 2007
Patrick Caulfield wrote:
> The length of the second element of the kvec array was not initialised before
> being added to the first one. This could cause invalid lengths to be passed to
> kernel_recvmsg
>
> Signed-Off-By: Patrick Caulfield <pcaulfie at redhat.com>
>
>
> ------------------------------------------------------------------------
>
> diff --git a/fs/dlm/lowcomms-tcp.c b/fs/dlm/lowcomms-tcp.c
> index 07e0a12..9bfe7fb 100644
> --- a/fs/dlm/lowcomms-tcp.c
> +++ b/fs/dlm/lowcomms-tcp.c
> @@ -299,6 +299,7 @@ static int receive_from_sock(struct connection *con)
> */
> iov[0].iov_len = con->cb.base - cbuf_data(&con->cb);
> iov[0].iov_base = page_address(con->rx_page) + cbuf_data(&con->cb);
> + iov[1].iov_len = 0;
> nvec = 1;
>
> /*
Just to add that this is already in RHEL5, but it needs to go upstream.
--
patrick
More information about the Cluster-devel
mailing list