[Cluster-devel] [PATCH/RFC] Standardize on /etc/sysconfig/cluster for init script

[Fabio M. Di Nitto]

On Thu, 2008-07-31 at 00:41 -0700, Joel Becker wrote:
> On Thu, Jul 31, 2008 at 05:24:36AM +0200, Fabio M. Di Nitto wrote:
> > diff --git a/cman/init.d/cman b/cman/init.d/cman
> > index 4ed6ec0..5ff172d 100644
> > --- a/cman/init.d/cman
> > +++ b/cman/init.d/cman
> > @@ -18,13 +18,8 @@
> >  
> >  . /etc/init.d/functions
> >  
> > -if [ -f /etc/sysconfig/cman ]; then
> > -    . /etc/sysconfig/cman
> > -    echo "/etc/sysconfig/cman has been deprecated in favour of /etc/sysconfig/cluster"
> > -    echo "Please consider switching to the new file"
> > -fi
> > -
> >  [ -f /etc/sysconfig/cluster ] && . /etc/sysconfig/cluster
> > +[ -f /etc/sysconfig/cman ] && . /etc/sysconfig/cman
> 
> 	What I meant was that /etc/sysconfig/cman does
> '.  /etc/sysconfig/cluster', and /etc/init.d/cman doesn't refer to
> /etc/sysconfig/cluster.  But what you've done at least honors the idea
> of "common things in /etc/sysconfig/cluster, cman-specific in
> /etc/sysconfig/cman".

Yes, but as I was telling you on IRC, we don't ship sysconfig/$name by
default because there is no need to. So if the users want /cluster, they
would have to add the snippet by themself.

> 	Oh, and you aren't the only cluster stack out there, so calling
> it "cluster" is rather presumptuous.  I should be able to install two
> cluster stacks side by side, even if they can't interact.

I will need to talk to the others to change this one. I didn't decide
its name. It was there before I even started looking into this bits.

Fabio