[Cluster-devel] [PATCH 3/4] libgfs2: Fix "Value stored is never read" warnings
Bob Peterson
rpeterso at redhat.com
Wed Aug 19 12:47:30 UTC 2009
----- "Andrew Price" <andy at andrewprice.me.uk> wrote:
| Building with CC="clang --analyze" gave the following warnings:
|
| - misc.c:126:8: warning: Although the value stored to 'ret' is used
| in
| the enclosing expression, the value is never actually read from
| 'ret'
| - fs_geometry.c:82:3: warning: Value stored to 'rgsize_specified' is
| never read
| - gfs1.c:308:3: warning: Value stored to 'f' is never read
|
| This patch makes them go away.
|
| Signed-off-by: Andrew Price <andy at andrewprice.me.uk>
| ---
(snip)
| + if (6 != ret)
Hi,
I prefer the form "if (ret != 6)" but this will work.
ACKed by Bob Peterson <rpeterso at redhat.com>
Regards,
Bob Peterson
Red Hat File Systems
More information about the Cluster-devel
mailing list