[Cluster-devel] [PATCH] dlm: Allow large nodeids

[David Teigland]

On Tue, Jan 27, 2009 at 02:06:30PM -0600, David Teigland wrote:
> On Tue, Jan 27, 2009 at 11:33:30AM +0000, Chrissie Caulfield wrote:
> > This an updated patch that uses hlists rather than list_heads to save
> > memory in the connection structure.
> > 
> > Thanks to Steven Whitehouse for the suggestion.
> 
> I fixed some checkpatch warnings, tested, and pushed into the "next" branch.

I take that back after hitting the following on unmount,

Pid: 4484, comm: umount Not tainted 2.6.29-rc2 #1
RIP: 0010:[<ffffffffa04ecfb4>]  [<ffffffffa04ecfb4>] foreach_conn+0x20/0x46 [dlm]
RSP: 0018:ffff880072db5d38  EFLAGS: 00010202
RAX: 0000000000000001 RBX: 6b6b6b6b6b6b6b6b RCX: 0000000000000000
RDX: ffffffffa04ed0dc RSI: 000000000000006b RDI: ffff880057998de0
RBP: ffff880072db5d58 R08: 0000000000000000 R09: ffff880057998de8
R10: 0000000000000000 R11: ffff88007dd428d8 R12: 0000000000000000
R13: ffffffffa04ecede R14: 0000000000006000 R15: 0000000000000100
FS:  00007fbce8f0b720(0000) GS:ffffffff80a33080(0000) knlGS:00000000f7f7a6c0
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00007ff8aa8d38e8 CR3: 0000000138c4a000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process umount (pid: 4484, threadinfo ffff880072db4000, task ffff8800738d4740)
Stack:
 ffff88007d187000 0000000000000000 ffff88007d187000 ffff88007c145fa0
 ffff880072db5d68 ffffffffa04ed35a ffff880072db5d78 ffffffffa04eaf20
 ffff880072db5db8 ffffffffa04eb299 ffff880072db5da8 ffff88007e85e198
Call Trace:
 [<ffffffffa04ed35a>] dlm_lowcomms_stop+0x68/0x82 [dlm]
 [<ffffffffa04eaf20>] threads_stop+0xe/0x15 [dlm]
 [<ffffffffa04eb299>] dlm_release_lockspace+0x372/0x3a4 [dlm]
 [<ffffffffa02720e0>] gdlm_unmount+0x28/0x49 [lock_dlm]
 [<ffffffffa047270f>] gfs2_unmount_lockproto+0x2d/0x52 [gfs2]
 [<ffffffffa0476bcc>] gfs2_lm_unmount+0x16/0x18 [gfs2]
 [<ffffffffa047afb7>] gfs2_put_super+0x180/0x190 [gfs2]
 [<ffffffff802afadc>] generic_shutdown_super+0x73/0xe8
 [<ffffffff802afb73>] kill_block_super+0x22/0x3a
 [<ffffffffa0476953>] gfs2_kill_sb+0x63/0x78 [gfs2]
 [<ffffffff802afc5c>] deactivate_super+0x68/0x7d
 [<ffffffff802c2aaf>] mntput_no_expire+0x103/0x149
 [<ffffffff802c3094>] sys_umount+0x2e2/0x341
 [<ffffffff8020c05b>] system_call_fastpath+0x16/0x1b
Code: 23 fe df 48 89 d8 5b 41 5c c9 c3 55 48 89 e5 41 55 49 89 fd 41 54 45 31 e4 53 48 83 ec 08 4a 8b 1c e5 e0 79 50 a0 48 85 db 74 15 <48> 8b 03 48 8d bb d0 fe ff ff 0f 18 08 41 ff d5 48 8b 1b eb e6
RIP  [<ffffffffa04ecfb4>] foreach_conn+0x20/0x46 [dlm]
 RSP <ffff880072db5d38>