[Cluster-devel] gfs_controld: Remove three unused functions
Steven Whitehouse
swhiteho at redhat.com
Wed Oct 14 14:20:11 UTC 2009
Hi,
It appears that these functions are never used,
Steve.
diff --git a/group/gfs_controld/cpg-new.c b/group/gfs_controld/cpg-new.c
index 23b7a86..e355590 100644
--- a/group/gfs_controld/cpg-new.c
+++ b/group/gfs_controld/cpg-new.c
@@ -530,42 +530,6 @@ static void node_history_init(struct mountgroup *mg, int nodeid,
node->added_seq = cg->seq; /* for queries */
}
-void node_history_cluster_add(int nodeid)
-{
- struct mountgroup *mg;
- struct node *node;
-
- list_for_each_entry(mg, &mountgroups, list) {
- node_history_init(mg, nodeid, NULL);
-
- node = get_node_history(mg, nodeid);
- if (!node) {
- log_error("node_history_cluster_add no nodeid %d",
- nodeid);
- return;
- }
-
- node->cluster_add_time = time(NULL);
- }
-}
-
-void node_history_cluster_remove(int nodeid)
-{
- struct mountgroup *mg;
- struct node *node;
-
- list_for_each_entry(mg, &mountgroups, list) {
- node = get_node_history(mg, nodeid);
- if (!node) {
- log_error("node_history_cluster_remove no nodeid %d",
- nodeid);
- return;
- }
-
- node->cluster_remove_time = time(NULL);
- }
-}
-
static void node_history_start(struct mountgroup *mg, int nodeid)
{
struct node *node;
diff --git a/group/gfs_controld/gfs_daemon.h b/group/gfs_controld/gfs_daemon.h
index 1d89497..7199c00 100644
--- a/group/gfs_controld/gfs_daemon.h
+++ b/group/gfs_controld/gfs_daemon.h
@@ -189,8 +189,6 @@ int set_mountgroups(int *count, struct gfsc_mountgroup **mgs_out);
int set_mountgroup_nodes(struct mountgroup *mg, int option, int *node_count,
struct gfsc_node **nodes_out);
void free_mg(struct mountgroup *mg);
-void node_history_cluster_add(int nodeid);
-void node_history_cluster_remove(int nodeid);
/* main.c */
int do_read(int fd, void *buf, size_t count);
@@ -202,7 +200,6 @@ void client_ignore(int ci, int fd);
void client_back(int ci, int fd);
struct mountgroup *create_mg(char *name);
struct mountgroup *find_mg(char *name);
-struct mountgroup *find_mg_id(uint32_t id);
void client_reply_remount(struct mountgroup *mg, int ci, int result);
void client_reply_join(int ci, struct gfsc_mount_args *ma, int result);
void client_reply_join_full(struct mountgroup *mg, int result);
diff --git a/group/gfs_controld/main.c b/group/gfs_controld/main.c
index 2b5a87e..959954c 100644
--- a/group/gfs_controld/main.c
+++ b/group/gfs_controld/main.c
@@ -178,17 +178,6 @@ struct mountgroup *find_mg(char *name)
return NULL;
}
-struct mountgroup *find_mg_id(uint32_t id)
-{
- struct mountgroup *mg;
-
- list_for_each_entry(mg, &mountgroups, list) {
- if (mg->id == id)
- return mg;
- }
- return NULL;
-}
-
enum {
Env_ACTION = 0,
Env_SUBSYSTEM,
More information about the Cluster-devel
mailing list