[Cluster-devel] bug in cman/init.d/cman.in?

[Dietmar Maurer]

This is a bug fix. I got wrong results.

Besides it does not lock sane to overwrite that global variable there (why?).

- Dietmar

> -----Original Message-----
> From: cluster-devel-bounces at redhat.com [mailto:cluster-devel-
> bounces at redhat.com] On Behalf Of Fabio M. Di Nitto
> Sent: Montag, 29. August 2011 14:06
> To: cluster-devel at redhat.com
> Subject: Re: [Cluster-devel] bug in cman/init.d/cman.in?
> 
> On 08/29/2011 10:44 AM, Dietmar Maurer wrote:
> > * do not overwrite global return status 'rtrn' - use local keyword
> >
> > Index: new/cman/init.d/cman.in
> >
> =================================================================
> ==
> > --- new.orig/cman/init.d/cman.in	2010-12-02 07:19:35.000000000 +0100
> > +++ new/cman/init.d/cman.in	2010-12-23 11:32:12.000000000 +0100
> > @@ -46,7 +48,7 @@
> >  status()
> >  {
> >  	pid=$(pidof $1 2>/dev/null)
> > -	rtrn=$?
> > +	local rtrn=$?
> >  	if [ $rtrn -ne 0 ]; then
> >  		echo "$1 is stopped"
> >  	else
> >
> >
> 
> Is this purely semantic or are you actually fixing a bug?
> 
> Reading the code, it doesn't look like it makes any difference... but I might not
> see it right.
> 
> Fabio
>