[Cluster-devel] [GFS2 PATCH] GFS2: Use dirty_inode in gfs2_dir_add

Steven Whitehouse swhiteho at redhat.com
Tue Nov 13 10:29:48 UTC 2012


Hi,

Now in the -nmw git tree. Thanks,

Steve.

On Mon, 2012-11-12 at 13:04 -0500, Bob Peterson wrote:
> Hi,
> 
> This patch changes the gfs2_dir_add function so that it uses
> the dirty_inode function (via mark_inode_dirty) rather than manually
> updating the dinode.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems
> 
> Signed-off-by: Bob Peterson <rpeterso at redhat.com> 
> ---
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index 259b088..9a35670 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -1676,16 +1676,11 @@ int gfs2_dir_add(struct inode *inode, const struct qstr *name,
>  				be16_add_cpu(&leaf->lf_entries, 1);
>  			}
>  			brelse(bh);
> -			error = gfs2_meta_inode_buffer(ip, &bh);
> -			if (error)
> -				break;
> -			gfs2_trans_add_bh(ip->i_gl, bh, 1);
>  			ip->i_entries++;
>  			ip->i_inode.i_mtime = ip->i_inode.i_ctime = CURRENT_TIME;
>  			if (S_ISDIR(nip->i_inode.i_mode))
>  				inc_nlink(&ip->i_inode);
> -			gfs2_dinode_out(ip, bh->b_data);
> -			brelse(bh);
> +			mark_inode_dirty(inode);
>  			error = 0;
>  			break;
>  		}
> 





More information about the Cluster-devel mailing list