[Cluster-devel] [PATCH 0/3] libcman: fix possible string nontermination

Christine Caulfield ccaulfie at redhat.com
Thu Oct 11 14:36:51 UTC 2012


in RHEL6 those strings are copied using strcpy - I think it was changed 
in the STABLE branch to strncpy after a coverity scan

TBH the original strcpy is quite safe as the strings come from internal 
sources and are pre-validated.

Anyway, the arrays are allocated as size+1 so the strings will never 
overflow.

NACK.

On 11/10/12 15:21, Jan Pokorný wrote:
> Hello once more,
>
> I discovered cases potentially leading to string overruns later
> in the processing.
>
> Jan Pokorný (3):
>    libcman: fix possible string nontermination: node name
>    libcman: fix possible string nontermination: barrier name
>    libcman: fix possible string nontermination: barrier name
>
>   cman/lib/libcman.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>




More information about the Cluster-devel mailing list