[Cluster-devel] [PATCH 6/9] dlm: plock: Add argument descriptions to notify

Joe Perches joe at perches.com
Sun Jul 20 18:23:40 UTC 2014


Function pointer arguments without type names
are not very clear.  Add them.

Signed-off-by: Joe Perches <joe at perches.com>
---
 fs/dlm/plock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
index f704458..e59d332 100644
--- a/fs/dlm/plock.c
+++ b/fs/dlm/plock.c
@@ -30,7 +30,7 @@ struct plock_op {
 
 struct plock_xop {
 	struct plock_op xop;
-	void *callback;
+	int (*callback)(struct file_lock *, struct file_lock *, int);
 	void *fl;
 	void *file;
 	struct file_lock flc;
@@ -190,7 +190,7 @@ static int dlm_plock_callback(struct plock_op *op)
 	struct file *file;
 	struct file_lock *fl;
 	struct file_lock *flc;
-	int (*notify)(void *, void *, int) = NULL;
+	int (*notify)(struct file_lock *fl, struct file_lock *cont, int result) = NULL;
 	struct plock_xop *xop = (struct plock_xop *)op;
 	int rv = 0;
 
-- 
1.8.1.2.459.gbcd45b4.dirty




More information about the Cluster-devel mailing list