[Cluster-devel] [PATCH 2/5] gfs2-utils: Expressly expunge 'expert mode'

[Andrew Price]

On 07/05/14 15:48, Bob Peterson wrote:
> ----- Original Message -----
>> mkfs.gfs2 and gfs2_jadd used struct gfs2_sbd.expert to put them into an
>> undocumented 'expert mode' but didn't really do anything useful in that
>> mode. Remove that field and other 'expert' references.
>>
>
> In the past, we've used mkfs.gfs2 expert mode to create certain test
> conditions, like very small resource groups. I don't think Nate uses
> this in any of his tests, but it might be worth asking.
> I've used it to try to recreate certain failing scenarios, but I haven't
> needed it in years. Are we sure we want to get rid of it?

I don't think we'd get much value out of testing resource group sizes 
which are technically unsupported. The resource group size validation 
and selection bits have all changed anyway and it doesn't really make 
sense any more. If it turns out there's a real use case for something 
like this then maybe we can add it back or implement a more focused 
solution.

Andy