[Cluster-devel] [PATCH] mkfs.gfs2: Always validate the locktable option
Bob Peterson
rpeterso at redhat.com
Thu Dec 10 13:20:20 UTC 2015
Hi Andy,
The patch looks good. The only thing that caught my eye was that
this statement looks kinda messy and could use a few more parentheses:
(snip)
> + if (strcmp(opts->lockproto, "lock_nolock") != 0 && !table_required)
The logic looks right, but I usually add more parens than necessary, for clarity.
Regards,
Bob Peterson
Red Hat File Systems
More information about the Cluster-devel
mailing list