[Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callback

[Jan Kara]

On Wed 18-02-15 08:51:54, Christoph Hellwig wrote:
> > +static void
> > +xfs_qm_fill_state(
> > +	struct qc_type_state *tstate,
> > +	struct xfs_mount *mp,
> > +	struct xfs_inode *ip,
> > +	xfs_ino_t ino)
> 
> > +/*
> > + * Return quota status information, such as enforcements, quota file inode
> > + * numbers etc.
> > + */
> > +static int
> > +xfs_fs_get_quota_state(
> > +	struct super_block *sb,
> > +	struct qc_state *state)
> 
> We usually tab-align the arguments in XFS prototypes.
  OK, fixed.

> Otherwise this patch looks good,
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
  Thanks.

								Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR