[Cluster-devel] [GFS2 PATCH] gfs2: Don't support fallocate on jdata files

[Bob Peterson]

----- Original Message -----
> We cannot provide an efficient implementation due to the headers
> on the data blocks, so there doesn't seem much point in having it.
> 
> Resolves: rhbz#1221331
> Signed-off-by: Abhi Das <adas at redhat.com>
> ---
>  fs/gfs2/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
> index c706c6d..8252115 100644
> --- a/fs/gfs2/file.c
> +++ b/fs/gfs2/file.c
> @@ -917,7 +917,7 @@ static long gfs2_fallocate(struct file *file, int mode,
> loff_t offset, loff_t le
>  	struct gfs2_holder gh;
>  	int ret;
>  
> -	if (mode & ~FALLOC_FL_KEEP_SIZE)
> +	if ((mode & ~FALLOC_FL_KEEP_SIZE) || gfs2_is_jdata(ip))
>  		return -EOPNOTSUPP;
>  
>  	mutex_lock(&inode->i_mutex);
> --
> 1.8.1.4
> 
> 
Hi,

Now that all the questions have been answered, I pushed this patch to the
for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=86066914edff2316cbed63aac8a87d5001441a16

Regards,

Bob Peterson
Red Hat File Systems