[Cluster-devel] [fsck.gfs2 v2 PATCH 32/40] fsck.gfs2: Eliminate redundant code in _fsck_bitmap_set

Bob Peterson rpeterso at redhat.com
Fri May 6 17:39:25 UTC 2016


Function _fsck_bitmap_set was checking if the block is unlinked,
and printing out messages identical to the alternative code path.
Therefore, the redundant code was eliminated.

rhbz#1268045
---
 gfs2/fsck/metawalk.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index 8a1748b..0df54df 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -185,17 +185,6 @@ int _fsck_bitmap_set(struct gfs2_inode *ip, uint64_t bblock,
 			       (unsigned long long)ip->i_di.di_num.no_addr,
 			       block_type_string(mark));
 
-		} else if (mark == GFS2_BLKST_UNLINKED) {
-			if (prevcount) {
-				log_info("\n");
-				prevcount = 0;
-			}
-			printf( _("(%s:%d) inode (0x%llx) references %s block"
-				  " (0x%llx): marking as '%s'\n"),
-			       caller, fline,
-			       (unsigned long long)ip->i_di.di_num.no_addr,
-			       btype, (unsigned long long)bblock,
-			       block_type_string(mark));
 		} else {
 			if (prevcount) {
 				log_info("\n");
-- 
2.5.5




More information about the Cluster-devel mailing list