[Cluster-devel] [PATCH v3 02/20] mm: fix mapping_set_error call in me_pagecache_dirty

Jeff Layton jlayton at redhat.com
Mon Apr 24 13:22:41 UTC 2017


The error code should be negative. Since this ends up in the default
case anyway, this is harmless, but it's less confusing to negate it.
Also, later patches will require a negative error code here.

Signed-off-by: Jeff Layton <jlayton at redhat.com>
Reviewed-by: Ross Zwisler <ross.zwisler at linux.intel.com>
Reviewed-by: Jan Kara <jack at suse.cz>
Reviewed-by: Matthew Wilcox <mawilcox at microsoft.com>
---
 mm/memory-failure.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 27f7210e7fab..4b56e53e5378 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -674,7 +674,7 @@ static int me_pagecache_dirty(struct page *p, unsigned long pfn)
 		 * the first EIO, but we're not worse than other parts
 		 * of the kernel.
 		 */
-		mapping_set_error(mapping, EIO);
+		mapping_set_error(mapping, -EIO);
 	}
 
 	return me_pagecache_clean(p, pfn);
-- 
2.9.3




More information about the Cluster-devel mailing list