[Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: Make pass2 go by directory rbtree for performance

[Bob Peterson]

Hi Andy,

Sorry for the delay. I guess I've been caught up in kernel work too long.

----- Original Message -----
| > +	for (tmp = osi_first(&dirtree); tmp; tmp = next) {
| > +		next = osi_next(tmp);
| 
| Why not 'for (next = osi_first(&dirtree); next; next = osi_next(next)) {' ?

The reason is: Any corruption caught might take the item off the list,
so it needs to be a "safe" version.
 
| ACK
| 
| Andy

Thanks for the review and the ACK. I'm under the gun on this (due to my
own fault, but nonetheless), so I'm going to push it to master.

Regards,

Bob Peterson
Red Hat File Systems