[Cluster-devel] [PATCH] dlm: NULL check before some freeing functions is not needed.

Thomas Meyer thomas at m3y3r.de
Sun Dec 2 20:52:11 UTC 2018


NULL check before some freeing functions is not needed.

Signed-off-by: Thomas Meyer <thomas at m3y3r.de>
---

diff -u -p a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -681,8 +681,7 @@ static int new_lockspace(const char *nam
  out_lkbidr:
 	idr_destroy(&ls->ls_lkbidr);
 	for (i = 0; i < DLM_REMOVE_NAMES_MAX; i++) {
-		if (ls->ls_remove_names[i])
-			kfree(ls->ls_remove_names[i]);
+		kfree(ls->ls_remove_names[i]);
 	}
  out_rsbtbl:
 	vfree(ls->ls_rsbtbl);




More information about the Cluster-devel mailing list