[Cluster-devel] [PATCH] gfs2: Fix loop in gfs2_rbm_find

Andreas Gruenbacher agruenba at redhat.com
Tue Dec 4 21:14:37 UTC 2018


On Tue, 4 Dec 2018 at 21:22, Andreas Gruenbacher <agruenba at redhat.com> wrote:
>
> In gfs2_rbm_find, fix the resource group wrap-around logic that commit
> e579ed4f44 broke.  Without this fix, gfs2_rbm_find can end up in an
> infinite loop in the worst case.

After some more review, it seems that the current mechanism of
exclusive resource group locking and the combination of how
gfs2_inplace_reserve and gfs2_alloc_blocks invoke gfs2_rbm_find
prevents an infinite loop in gfs2_rbm_find. This fix still prevents
unnecessary bitmap scanning though.

Andreas




More information about the Cluster-devel mailing list