[Cluster-devel] [PATCH] gfs2: Fix fallocate chunk size

Bob Peterson rpeterso at redhat.com
Tue Feb 20 15:36:16 UTC 2018


----- Original Message -----
| The chunk size of allocations in __gfs2_fallocate is calculated
| incorrectly.  The size can collapse, causing __gfs2_fallocate to
| allocate one block at a time, which is very inefficient.  This needs
| fixing in two places:
| 
| In gfs2_quota_lock_check, always set ap->allowed to UINT_MAX to indicate
| that there is no quota limit.  This fixes callers that rely on
| ap->allowed to be set even when quotas are off.
| 
| In __gfs2_fallocate, reset max_blks to UINT_MAX in each iteration of the
| loop to make sure that allocation limits from one resource group won't
| spill over into another resource group.
| 
| Signed-off-by: Andreas Gruenbacher <agruenba at redhat.com>

Hi,

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:

https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=3fc7c7e1cfaac17cb7b0bfd54e5abf9b1ef2b819

Regards,

Bob Peterson
Red Hat File Systems




More information about the Cluster-devel mailing list