[Cluster-devel] [PATCH] iomap: Add inline data support to iomap_readpage_actor

Christoph Hellwig hch at lst.de
Mon Jul 2 12:52:30 UTC 2018


On Sun, Jul 01, 2018 at 11:43:43PM +0200, Andreas Gruenbacher wrote:
> > +               WARN_ON_ONCE(plen != PAGE_SIZE);
> 
> Inline mappings only extend to the end of the file (iomap->offset == 0
> && iomap->length == inode->i_size), so length and plen will be
> inode->i_size here. This assertion should just be removed.

But we should generally still return PAGE_SIZE from iomap_begin
because we cover the whole page and zero the rest, don't we?

Either way, I can remove the assert from now.




More information about the Cluster-devel mailing list