[Cluster-devel] [PATCH] gfs2: add error handling for kmem_cache_zalloc

Andreas Gruenbacher agruenba at redhat.com
Tue Jun 12 08:23:30 UTC 2018


On 12 June 2018 at 09:24, cgxu519 at gmx.com <cgxu519 at gmx.com> wrote:
>
>> 在 2018年6月12日,上午11:38,Zhouyang Jia <jiazhouyang09 at gmail.com> 写道:
>>
>> When kmem_cache_zalloc fails, the lack of error-handling code may
>> cause unexpected results.
>>
>> This patch adds error-handling code after calling kmem_cache_zalloc.
>
> Should not fail on this case.

Indeed, with the __GFP_NOFAIL flag, kmem_cache_zalloc will not fail.
This is documented in include/linux/gfp.h.

Thanks,
Andreas




More information about the Cluster-devel mailing list