[Cluster-devel] [RHEL7.9.z PATCH 0/2] Circular lock dependency on unmount

Bob Peterson rpeterso at redhat.com
Thu Dec 3 15:22:39 UTC 2020


This patch set fixes a circular lock dependency flagged by LOCKDEP when a
gfs2 file system is unmounted. The first patch adds new helper functions
for holding and releasing the freeze glock. Functionality should be the same.
The second patch moves the freeze locks that used to be inside the
make_fs_ro and _rw functions to their callers. The unmount caller, however,
is exempted to avoid the lock dependency. The change means that function
init_threads is now called from within the freeze lock, but that should
not matter.

Bob Peterson (2):
  gfs2: Add common helper for holding and releasing the freeze glock
  gfs2: move freeze glock outside the make_fs_rw and _ro functions

 fs/gfs2/ops_fstype.c | 33 +++++++++++++++--------------
 fs/gfs2/recovery.c   |  6 ++----
 fs/gfs2/super.c      | 45 ++++-----------------------------------
 fs/gfs2/util.c       | 50 ++++++++++++++++++++++++++++++++++++++++++--
 fs/gfs2/util.h       |  3 +++
 5 files changed, 74 insertions(+), 63 deletions(-)

-- 
2.28.0




More information about the Cluster-devel mailing list