[Cluster-devel] [gfs2:master.bob.bio_set5 2/2] fs/gfs2/recovery.c:592:6: warning: variable 'rv' set but not used

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git master.bob.bio_set5
head:   bc212ae34635fa1d829e6075f17e561dd9d91575
commit: bc212ae34635fa1d829e6075f17e561dd9d91575 [2/2] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal
config: nds32-randconfig-p002-20201222 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=bc212ae34635fa1d829e6075f17e561dd9d91575
        git remote add gfs2 https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
        git fetch --no-tags gfs2 master.bob.bio_set5
        git checkout bc212ae34635fa1d829e6075f17e561dd9d91575
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   fs/gfs2/recovery.c: In function 'gfs2_recover_journal':
>> fs/gfs2/recovery.c:592:6: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
     592 |  int rv;
         |      ^~


vim +/rv +592 fs/gfs2/recovery.c

bc212ae34635fa1 Bob Peterson      2020-12-21  588  
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  589  int gfs2_recover_journal(struct gfs2_jdesc *jd, bool wait)
9ac1b4d9b6f885c Steven Whitehouse 2008-11-19  590  {
bc212ae34635fa1 Bob Peterson      2020-12-21  591  	struct gfs2_sbd *sdp = GFS2_SB(jd->jd_inode);
fe64d517df0970a Steven Whitehouse 2009-05-19 @592  	int rv;
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  593  
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  594  	if (test_and_set_bit(JDF_RECOVERY, &jd->jd_flags))
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  595  		return -EBUSY;
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  596  
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  597  	/* we have JDF_RECOVERY, queue should always succeed */
bc212ae34635fa1 Bob Peterson      2020-12-21  598  	rv = queue_work(gfs_recovery_wq, &sdp->sd_recovery_work);
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  599  
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  600  	if (wait)
743162013d40ca6 NeilBrown         2014-07-07  601  		wait_on_bit(&jd->jd_flags, JDF_RECOVERY,
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  602  			    TASK_UNINTERRUPTIBLE);
6ecd7c2dd9f5dd4 Tejun Heo         2010-07-20  603  
376d37788b56bc2 David Teigland    2012-01-09  604  	return wait ? jd->jd_recover_error : 0;
9ac1b4d9b6f885c Steven Whitehouse 2008-11-19  605  }
9ac1b4d9b6f885c Steven Whitehouse 2008-11-19  606  

:::::: The code at line 592 was first introduced by commit
:::::: fe64d517df0970a68417184a12fcd4ba0589cc28 GFS2: Umount recovery race fix

:::::: TO: Steven Whitehouse <swhiteho at redhat.com>
:::::: CC: Steven Whitehouse <swhiteho at redhat.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 36635 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20201229/cbbd18bf/attachment.gz>