[Cluster-devel] [GFS2 PATCH 0/2] Fix regression in "Ignore journal log writes for jdata holes"

Bob Peterson rpeterso at redhat.com
Thu Nov 12 15:44:55 UTC 2020


----- Original Message -----
> Patch b2a846dbef4e ("gfs2: Ignore journal log writes for jdata holes"
> caused a regression. It fixed one specific problem while breaking others.
> The problem was that it changed the behavior of function gfs2_block_map
> which is used by multiple callers so it had unintended consequences for
> other callers.
> 
> This patch set reverts the patch and replaces it with a more targeted
> solution that fixes just the one case it needs to.
> 
> Bob Peterson (2):
>   Revert "gfs2: Ignore journal log writes for jdata holes"
>   gfs2: Make special version of gfs2_get_block_noalloc for jdata
> 
>  fs/gfs2/aops.c | 30 ++++++++++++++++++++++++++++--
>  fs/gfs2/bmap.c |  8 ++------
>  fs/gfs2/log.c  |  2 ++
>  3 files changed, 32 insertions(+), 8 deletions(-)
> 
> --
> 2.26.2

NACK. Ignore this for now. Something's wrong and I'm investigating.

Regards,

Bob Peterson




More information about the Cluster-devel mailing list