[Cluster-devel] [PATCH -next] gfs2: Use list_move_tail instead of list_del/list_add_tail

Baokun Li libaokun1 at huawei.com
Tue Jun 8 03:12:44 UTC 2021


Using list_move_tail() instead of list_del() + list_add_tail().

Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Baokun Li <libaokun1 at huawei.com>
---
 fs/gfs2/glock.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index f6cae2ee1c83..902dd7385462 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -212,8 +212,7 @@ void gfs2_glock_add_to_lru(struct gfs2_glock *gl)
 
 	spin_lock(&lru_lock);
 
-	list_del(&gl->gl_lru);
-	list_add_tail(&gl->gl_lru, &lru_list);
+	list_move_tail(&gl->gl_lru, &lru_list);
 
 	if (!test_bit(GLF_LRU, &gl->gl_flags)) {
 		set_bit(GLF_LRU, &gl->gl_flags);





More information about the Cluster-devel mailing list