[Cluster-devel] [RFC v3 4/7] iomap: Add iomap_folio_prepare helper
Christoph Hellwig
hch at infradead.org
Wed Dec 28 15:55:42 UTC 2022
On Sun, Dec 25, 2022 at 09:12:34AM +0000, Matthew Wilcox wrote:
> > > I was looking at it from the filesystem point of view: this helper is
> > > meant to be used in ->folio_prepare() handlers, so
> > > iomap_folio_prepare() seemed to be a better name than
> > > __iomap_get_folio().
> >
> > Well, I think the right name for the methods that gets a folio is
> > probably ->folio_get anyway.
>
> For the a_ops, the convention I've been following is:
>
> folio_mark_dirty()
> -> aops->dirty_folio()
> -> iomap_dirty_folio()
>
> ie VERB_folio() as the name of the operation, and MODULE_VERB_folio()
> as the implementation. Seems to work pretty well.
Yeay, ->get_folio sounds fine if not even better as it matches
filemap_get_folio.
More information about the Cluster-devel
mailing list