[Cluster-devel] [PATCH v2 07/19] md: raid5: use __bio_add_page to add single page to new bio

Song Liu song at kernel.org
Fri Mar 31 17:47:55 UTC 2023


On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn
<johannes.thumshirn at wdc.com> wrote:
>
> The raid5-ppl submission code uses bio_add_page() to add a page to a
> newly created bio. bio_add_page() can fail, but the return value is never
> checked. For adding consecutive pages, the return is actually checked and
> a new bio is allocated if adding the page fails.
>
> Use __bio_add_page() as adding a single page to a newly created bio is
> guaranteed to succeed.
>
> This brings us a step closer to marking bio_add_page() as __must_check.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn at wdc.com>
> Reviewed-by: Damien Le Moal <damien.lemoal at opensource.wdc.com>

Acked-by: Song Liu <song at kernel.org>



More information about the Cluster-devel mailing list