[Cluster-devel] [PATCH v2 16/19] md: raid1: use __bio_add_page for adding single page to bio

Song Liu song at kernel.org
Fri Mar 31 17:59:57 UTC 2023


On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn
<johannes.thumshirn at wdc.com> wrote:
>
> The sync request code uses bio_add_page() to add a page to a newly created bio.
> bio_add_page() can fail, but the return value is never checked.
>
> Use __bio_add_page() as adding a single page to a newly created bio is
> guaranteed to succeed.
>
> This brings us a step closer to marking bio_add_page() as __must_check.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn at wdc.com>
> Reviewed-by: Damien Le Moal <damien.lemoal at opensource.wdc.com>

Acked-by: Song Liu <song at kernel.org>

Thanks!



More information about the Cluster-devel mailing list