<div dir="ltr">thanks, i was doing some thinking the other night, given the goal is for this agent to work with oVirt, i'm not sure that all the oVirt required commands are supported in the agent code for this to work.<div>
Also there's a comment about the port being required as a large path, this is very unlikely to work with oVirt, I need to consult that group to find out and perhaps submit a newer version.</div><div><br></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Mar 21, 2014 at 10:50 AM, Marek Grac <span dir="ltr"><<a href="mailto:mgrac@redhat.com" target="_blank">mgrac@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<div class=""><br>
<br>
On 03/19/2014 10:26 PM, David Smith wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi marek, sure, no problem, here's the changes; also sent to cluster-devel.<br>
</blockquote>
<br></div>
thanks, for next time it will be easier to you and other reviewers if you will sent a patch in a standard format. Take a look at<br>
<a href="http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html" target="_blank">http://alblue.bandlem.com/<u></u>2011/12/git-tip-of-week-<u></u>patches-by-email.html</a><div class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I've already tested by manually running the fence-raritan agent that this is working and functional<br>
<br>
</blockquote></div>
code looks pretty good and after few minor changes it can be accepted.<br>
<br>
These are my comments:<br>
* please remove commented line of source code<br>
* exception checking 'Due to limitations ...' is not required any more because we have subpackage for every fence-agent so dependencies can be solved properly<br>
* default value can be now set more easier (--ipport in this case)<br>
all_opt["ipport"]["default"] = "23"<br>
* please add support also for delay before login which is very useful for 2-node clusters<br>
if options["--action"] in ["off", "reboot"]:<br>
time.sleep(int(options["--<u></u>delay"]))<span class="HOEnZb"><font color="#888888"><br>
<br>
m,<br>
<br>
</font></span></blockquote></div><br></div>