[Crash-utility] Problem with irq command on ARM core file

[Karlsson, Jan]

Hi Dave

I tried the irq command on an ARM vmcore file with a fairly new kernel (3.4.0) and it did not work.

crash> irq
irq: cannot determine number of IRQs

The problem is in arm.c

                   if (symbol_exists("irq_desc"))
                             ARRAY_LENGTH_INIT(machdep->nr_irqs, irq_desc,
                                                  "irq_desc", NULL, 0);

as the symbol irq_desc does not exist any longer. Looking at x86_64.c I changed this to

                   if (symbol_exists("irq_desc"))
                             ARRAY_LENGTH_INIT(machdep->nr_irqs, irq_desc,
                                                  "irq_desc", NULL, 0);
                   else if (kernel_symbol_exists("nr_irqs"))
                             get_symbol_data("nr_irqs", sizeof(unsigned int),
                                       &machdep->nr_irqs);

and then the command worked as it should again.

Jan

Jan Karlsson
Senior Software Engineer
MIB

Sony Mobile Communications
Tel: +46703062174
sonymobile.com<http://sonymobile.com/>

[cid:image001.jpg at 01CE10F3.4F482AB0]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20130222/3f45399a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 2843 bytes
Desc: image001.jpg
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20130222/3f45399a/attachment.jpg>