[Crash-utility] [PATCH] Makefile: reduce crash build log
HAGIO KAZUHITO(萩尾 一仁)
k-hagio-ab at nec.com
Mon Feb 22 01:12:34 UTC 2021
-----Original Message-----
> Hi, Kazu
>
> Thanks for the improvement.
> 在 2021年02月19日 13:43, HAGIO KAZUHITO(萩尾 一仁) 写道:
> > Currently the verbose output of tar command when extracting the
> > GDB source files occupies more than half of crash build log.
> > It is not so helpful and makes the build log longer needlessly
> > especially on CI build test. Let's stop it.
> >
> > Also reduce about 600 lines of crash build log with wget's
> > "--progress=dot:mega" option when stderr is not a tty.
> >
> > Signed-off-by: Kazuhito Hagio <k-hagio-ab at nec.com>
> > ---
> > current log:
> > https://travis-ci.org/github/k-hagio/crash/jobs/759585719
> > with this patch:
> > https://travis-ci.org/github/k-hagio/crash/jobs/759589437
> >
> > Makefile | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index f66eba7418d1..b3c0d3a7f75b 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -258,8 +258,9 @@ gdb_unzip:
> > @if [ ! -f ${GDB}.tar.gz ] && [ ! -f /usr/bin/wget ]; then \
> > echo /usr/bin/wget is required to download ${GDB}.tar.gz; echo; exit 1; fi
> > @if [ ! -f ${GDB}.tar.gz ] && [ -f /usr/bin/wget ]; then \
> > - wget http://ftp.gnu.org/gnu/gdb/${GDB}.tar.gz; fi
> > - @tar --exclude-from gdb.files -xvzmf ${GDB}.tar.gz
> > + [ ! -t 2 ] && WGET_OPTS="--progress=dot:mega"; \
> > + wget $$WGET_OPTS http://ftp.gnu.org/gnu/gdb/${GDB}.tar.gz; fi
> > + @tar --exclude-from gdb.files -xzmf ${GDB}.tar.gz
> > @make --no-print-directory gdb_patch
> >
> > gdb_patch:
> >
>
> Acked-by: Lianbo Jiang <lijiang at redhat.com>
Thanks, applied:
https://github.com/crash-utility/crash/commit/464edc6e6636c01521b46ec64134b90c7e7ced11
Kazu
More information about the Crash-utility
mailing list