[Crash-utility] [PATCH v3 1/1] tools: list: create O option for specifying head node offset (Firo Yang)
HAGIO KAZUHITO(萩尾 一仁)
k-hagio-ab at nec.com
Thu Jun 17 02:45:52 UTC 2021
-----Original Message-----
> Hi, Firo
> Thank you for the explanation.
> I have no objection, because it's just a cosmetic change in the code
> style. Acked-by: Lianbo Jiang <lijiang at redhat.com>
> > Hi Lianbo, after thinking about this code for a while, I think the code
> > refactoring is not necessary because
> > 1) the original code makes more sense to express the mutual exclusive
> > semantics between -H (ld->flags & LIST_HEAD_POINTER) and -h.
> >
> > 2) LIST_HEAD_OFFSET_ENTERED and LIST_OFFSET_ENTERED don't have to
> > be at same level because LIST_HEAD_OFFSET_ENTERED is just a sub-option for -h.
> >
> > So please consider accepting the original patch.
Ok, applied with some cosmetic adjustments I found.
https://github.com/crash-utility/crash/commit/f091b5e76d2d6e81b12cd40df7b5863c9e2efed1
Thanks,
Kazu
More information about the Crash-utility
mailing list