[Crash-utility] [PATCH] Makefile: Fix unnecessary re-patching with coreutils-9.0

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Tue Aug 9 00:28:26 UTC 2022


"sum" command in coreutils-9.0 (e.g. Fedora 36) started to output a file
name.  As a result, "make" always detects a change of gdb-10.2.patch
wrongly and re-applies it unnecessarily.

Use "cmp" command instead.

Signed-off-by: Kazuhito Hagio <k-hagio-ab at nec.com>
---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 162c2baa5164..020fc8207277 100644
--- a/Makefile
+++ b/Makefile
@@ -272,7 +272,7 @@ rebuild:
  	@if [ ! -f ${GDB}/${GDB}.patch ]; then \
  	  touch ${GDB}/${GDB}.patch; fi
  	@if [ -f ${GDB}.patch ] && [ -s ${GDB}.patch ] && \
-	  [ "`sum ${GDB}.patch`" != "`sum ${GDB}/${GDB}.patch`" ]; then \
+	  ! cmp -s ${GDB}.patch ${GDB}/${GDB}.patch; then \
  	  (sh -x ${GDB}.patch ${TARGET}; patch -N -p0 -r- --fuzz=0 < ${GDB}.patch; cp ${GDB}.patch ${GDB}; cd ${GDB}; \
  	  $(MAKE) CRASH_TARGET=${TARGET}) \
  	else (cd ${GDB}/gdb; $(MAKE) CRASH_TARGET=${TARGET}); fi
-- 
2.31.1


More information about the Crash-utility mailing list