[Crash-utility] [PATCH] Fix errors when rebuild with updated gdb-10.2.patch

[lijiang]

Hi, Kazu
Thank you for the fix.
On Thu, Jan 27, 2022 at 3:07 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab at nec.com>
wrote:

> The gdb-10.2.patch forgot the role that acts as a shell script that
> restores gdb files to its original state and exits.  Without the patch,
> the following errors are emitted when rebuiding crash with an updated
> gdb-10.2.patch.
>
>   $ make warn
>   TARGET: X86_64
>    CRASH: 8.0.0++
>      GDB: 10.2
>
>   + --- gdb-10.2/Makefile.in.orig
>   gdb-10.2.patch: line 11: ---: command not found
>   + +++ gdb-10.2/Makefile.in
>   gdb-10.2.patch: line 12: +++: command not found
>   + @@ -340,6 +340,9 @@ AR_FOR_BUILD = @AR_FOR_BUILD@
>   gdb-10.2.patch: line 13: @@: command not found
>   + AS_FOR_BUILD = @AS_FOR_BUILD@
>   gdb-10.2.patch: line 14: AS_FOR_BUILD: command not found
>   + CC_FOR_BUILD = @CC_FOR_BUILD@
>   gdb-10.2.patch: line 15: CC_FOR_BUILD: command not found
>   + CFLAGS_FOR_BUILD = @CFLAGS_FOR_BUILD@
>   gdb-10.2.patch: line 16: CFLAGS_FOR_BUILD: command not found
>   gdb-10.2.patch: line 17: syntax error near unexpected token
>   `${CRASH_TARGET},'
>   gdb-10.2.patch: line 17: `+ifeq (${CRASH_TARGET}, PPC64)'
>
> Signed-off-by: Kazuhito Hagio <k-hagio-ab at nec.com>
> ---
>  gdb-10.2.patch | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gdb-10.2.patch b/gdb-10.2.patch
> index f5e4c06e6f97..c5aa0bf79691 100644
> --- a/gdb-10.2.patch
> +++ b/gdb-10.2.patch
> @@ -8,6 +8,11 @@
>  # shell script that can restore any gdb file to its original state prior
>  # to all subsequent patch applications.
>
> +#tar xvzmf gdb-10.2.tar.gz \
> +#      gdb-10.2/gdb/symtab.c
>

The above code has been commented out,  do you have any concerns?

Thanks.
Lianbo

+
> +exit 0
> +
>  --- gdb-10.2/Makefile.in.orig
>  +++ gdb-10.2/Makefile.in
>  @@ -340,6 +340,9 @@ AR_FOR_BUILD = @AR_FOR_BUILD@
> --
> 2.27.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20220210/4a664d5c/attachment.htm>