[Crash-utility] [PATCH v2] arm64: Use CONFIG_ARM64_VA_BITS to initialize VA_BITS_ACTUAL

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Mon Feb 14 01:55:09 UTC 2022


-----Original Message-----
> We can get VA_BITS_ACTUAL from CONFIG_ARM64_VA_BITS by guess.
> 
> Without this patch, we may need to use "--machdep vabits_actual=48" to
> set the VA_BITS_ACTUAL.
> 
> Signed-off-by: Huang Shijie <shijie at os.amperecomputing.com>
> ---
> v1 --> v2:
> 	Remove the DISKDUMP limit.

Thanks for the v2 patch, it looks good to me.

Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>

> ---
>  arm64.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arm64.c b/arm64.c
> index 4f2c2b5..de1038a 100644
> --- a/arm64.c
> +++ b/arm64.c
> @@ -4170,6 +4170,11 @@ arm64_calc_VA_BITS(void)
>  			} else if (machdep->machspec->VA_BITS_ACTUAL) {
>  				machdep->machspec->VA_BITS = machdep->machspec->VA_BITS_ACTUAL;
>  				machdep->machspec->VA_START = _VA_START(machdep->machspec->VA_BITS_ACTUAL);
> +			} else if (machdep->machspec->CONFIG_ARM64_VA_BITS) {
> +				/* guess */
> +				machdep->machspec->VA_BITS_ACTUAL =
> machdep->machspec->CONFIG_ARM64_VA_BITS;
> +				machdep->machspec->VA_BITS = machdep->machspec->CONFIG_ARM64_VA_BITS;
> +				machdep->machspec->VA_START = _VA_START(machdep->machspec->VA_BITS_ACTUAL);
>  			} else
>  				error(FATAL, "cannot determine VA_BITS_ACTUAL\n");
>  		}
> --
> 2.30.2





More information about the Crash-utility mailing list