[Crash-utility] [PATCH v3] Makefile: crash multi-target and multithread compile support

[lijiang]

On Tue, Feb 22, 2022 at 1:19 PM <crash-utility-request at redhat.com> wrote:

> Date: Tue, 22 Feb 2022 04:25:18 +0000
> From: HAGIO KAZUHITO(?????)     <k-hagio-ab at nec.com>
> To: Tao Liu <ltao at redhat.com>
> Cc: "Discussion list for crash utility usage,   maintenance and
>         development" <crash-utility at redhat.com>
> Subject: Re: [Crash-utility] [PATCH v3] Makefile: crash multi-target
>         and     multithread compile support
> Message-ID:
>         <
> TYYPR01MB6777A51225457BCC4EF8C5C0DD3B9 at TYYPR01MB6777.jpnprd01.prod.outlook.com
> >
>
> Content-Type: text/plain; charset="iso-2022-jp"
>
> -----Original Message-----
> > This patch will enable making crash as follows:
> >
> >     $ make -j8 warn lzo zstd
> >


Thank you for the patch, Tao.
The v3 looks good to me. Applied and added the error in patch log.

Lianbo


>
> > Signed-off-by: Tao Liu <ltao at redhat.com>
>
> Thanks, looks good to me.
>
> Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>
>
> Kazu
>
>
> > ---
> >  Makefile | 51 ++++++++++++++++++++++++---------------------------
> >  1 file changed, 24 insertions(+), 27 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index ede87a1..1ef96fa 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -223,6 +223,28 @@ ifneq ($(target),)
> >  CONF_TARGET_FLAG="-t$(target)"
> >  endif
> >
> > +ifeq ($(findstring warn,$(MAKECMDGOALS)),warn)
> > +CONF_TARGET_FLAG += -w
> > +endif
> > +ifeq ($(findstring Warn,$(MAKECMDGOALS)),Warn)
> > +CONF_TARGET_FLAG += -W
> > +endif
> > +ifeq ($(findstring nowarn,$(MAKECMDGOALS)),nowarn)
> > +CONF_TARGET_FLAG += -n
> > +endif
> > +ifeq ($(findstring lzo,$(MAKECMDGOALS)),lzo)
> > +CONF_TARGET_FLAG += -x lzo
> > +endif
> > +ifeq ($(findstring snappy,$(MAKECMDGOALS)),snappy)
> > +CONF_TARGET_FLAG += -x snappy
> > +endif
> > +ifeq ($(findstring zstd,$(MAKECMDGOALS)),zstd)
> > +CONF_TARGET_FLAG += -x zstd
> > +endif
> > +ifeq ($(findstring valgrind,$(MAKECMDGOALS)),valgrind)
> > +CONF_TARGET_FLAG += -x valgrind
> > +endif
> > +
> >  # To build the extensions library by default, uncomment the third
> command
> >  # line below.  Otherwise they can be built by entering "make
> extensions".
> >
> > @@ -305,33 +327,8 @@ install:
> >  unconfig: make_configure
> >       @./configure -u
> >
> > -warn: make_configure
> > -     @./configure ${CONF_TARGET_FLAG} -w -b
> > -     @$(MAKE) gdb_merge
> > -
> > -Warn: make_configure
> > -     @./configure ${CONF_TARGET_FLAG} -W -b
> > -     @$(MAKE) gdb_merge
> > -
> > -nowarn: make_configure
> > -     @./configure ${CONF_TARGET_FLAG} -n -b
> > -     @$(MAKE) gdb_merge
> > -
> > -lzo: make_configure
> > -     @./configure -x lzo ${CONF_TARGET_FLAG} -w -b
> > -     @$(MAKE) gdb_merge
> > -
> > -snappy: make_configure
> > -     @./configure -x snappy ${CONF_TARGET_FLAG} -w -b
> > -     @$(MAKE) gdb_merge
> > -
> > -zstd: make_configure
> > -     @./configure -x zstd ${CONF_TARGET_FLAG} -w -b
> > -     @$(MAKE) gdb_merge
> > -
> > -valgrind: make_configure
> > -     @./configure -x valgrind ${CONF_TARGET_FLAG} -w -b
> > -     @$(MAKE) gdb_merge
> > +warn Warn nowarn lzo snappy zstd valgrind: all
> > +     @true  #dummy
> >
> >  main.o: ${GENERIC_HFILES} main.c
> >       ${CC} -c ${CRASH_CFLAGS} main.c ${WARNING_OPTIONS} ${WARNING_ERROR}
> > --
> > 2.33.1
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20220223/69c2d886/attachment.htm>